e13mort / stf-console-client Goto Github PK

it will be useful to select devices from specific department.
Actually it is even better to have possibility to filter devices by any parameter

command line parameters are useful when using this tool manually but it will be more convenient to keep such filters in separate file(json / yaml) for automation and specify only some kind of filter name.

Many devices have name :
./open-stf-console-client.sh -l
abi: armeabi-v7a serial: 2f96e4e2, sdk: 23
abi: arm64-v8a serial: 05157df591030e3a, sdk: 23
abi: armeabi-v7a serial: 44c1be6e, sdk: 19
Nexus 5 abi: armeabi-v7a serial: 064b2b050adf279b, sdk: 23
abi: armeabi-v7a serial: 420366cce4b15200, sdk: 19
Xperia Z2 Tablet abi: armeabi-v7a serial: CB5128094L, sdk: 23
abi: armeabi-v7a serial: LGD72434524e22, sdk: 21
Nexus 9 abi: arm64-v8a serial: HT4CVWV00329, sdk: 25
abi: armeabi-v7a serial: YT9110DWHZ, sdk: 19
abi: x86 serial: EBAZCY27A405, sdk: 19
Nexus 6P abi: arm64-v8a serial: ENU7N15B14007999, sdk: 25
Nexus 6 abi: armeabi-v7a serial: ZX1G428NHF, sdk: 23
abi: arm64-v8a serial: 81HBBMT228AV, sdk: 22
abi: armeabi-v7a serial: N9JILXNHCF, sdk: 19
abi: armeabi-v7a serial: MVGEKV4T49Z9BA6D, sdk: 19
abi: armeabi-v7a serial: b0efb6d9, sdk: 21
abi: armeabi-v7a serial: R32CB01XN5B, sdk: 19
Nexus 6P abi: arm64-v8a serial: ENU7N15B06000967, sdk: 25
abi: arm64-v8a serial: RQ30036Z8F, sdk: 23

So we need more information and possibility to filter by them, manufacturer and model for example.

in order to determine on which side issues occurs please add logging system. Suggest to force logging with command line parameter with specifying log file e.g. stf connect --log logs/error.log

if some of the devices fails to connect for some reason client doesn't attempting to connect to other devices

we have some flaky device on our farm which causing failure to connect any devices

client disconnects all devices reserved by particular farm account, even those which weren't linked by "this" client connect

subj is crucial for CI system because due to particular adb token can be linked with only one farm account so concurrent builds / jobs will affect each other. If one job disconnect all another will lose all the devices during build run

sometimes stf client stucks on attempt to connect the device. It's probably some stf farm issue but we need some reasonable timeout for connection after which next device should be connected.

it's might be useful to have this timeout as parameter

-api selects devices with api version >= specified number, but with this parameters I couldn't select devices with Android versions 5 and 6 for example.

Currently there is no way to release device from farm. Even if device was disconnected via adb status 'automation' persist. Don't know if there is some release timeout and how big it is.

It doesn't disconnect form adb when I run the disconnect command.

-l should return list of not busy devices
-c should connect to not busy devices

subj. E.g. stf -c -n "Nexus 5" -n "Nexus 9" -n "Xperia Tablet"
currently it will only connect first one and ignore others