GithubHelp home page GithubHelp logo

ealva-com / ealvatag Goto Github PK

View Code? Open in Web Editor NEW
29.0 29.0 6.0 111.88 MB

Java library for reading and writing tag information of audio files

License: GNU Lesser General Public License v3.0

Batchfile 0.01% Java 99.99%

ealvatag's People

Contributors

badmannersteam avatar fhuberts avatar gravelld avatar hendriks73 avatar hennr avatar ijabz avatar opoplawski avatar pandasys avatar pathrik avatar pere00 avatar solomax avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

ealvatag's Issues

issue with edit tags in android 11

i have taken access by Mediastore.writeRequest() then try to edit
ealvatag.audio.exceptions.CannotWriteException: ealvatag.audio.exceptions.UnableToCreateFileException: Cannot modify /storage/emulated/0/Music/Chhapaak - Arijit Singh.mp3 because do not have permissions to create files in the folder

Setting FLAC artwork on Android causes java.lang.ClassNotFoundException

MP3 artwork works fine, only FLAC does this presumably because Android doesn't have ImageIO.

Caused by: java.lang.ClassNotFoundException: Didn't find class "javax.imageio.ImageIO" on path: DexPathList[[zip file "/data/app/com.nick80835.add-jvbwdoBL7ihYF5PkWATMZw==/base.apk"],nativeLibraryDirectories=[/data/app/com.nick80835.add-jvbwdoBL7ihYF5PkWATMZw==/lib/arm64, /system/lib64, /vendor/lib64, /system/product/lib64]]

This happens when attempting to perform addArtwork on the FLAC files tags.

val thisTempFile = File.createTempFile(thisData.trackId.toString(), ".tmp", cacheDir) thisTempFile.writeBytes(thisAlbumArtBig) val thisArtwork = ArtworkFactory.createArtworkFromFile(thisTempFile) thisAudioTag.addArtwork(thisArtwork)

This file does not appear to be an Mp4 Audio file

I have seen issue#1 but mine is an audio file created with Android MediaCodec encoder. Do you think MediaCodec creates non conforming M4A too?

Error:
This file does not appear to be an Mp4 Audio file, could be corrupted or video
2019-01-17 15:13:23.310 1136-1542/com.nll.asr W/System.err: at yya.(Mp4UdtaBox.java:56)

File: https://bitbucket.org/ijabz/jaudiotagger/issues/attachments/277/ijabz/jaudiotagger/1547676684.77/277/test%202019_01_16_22_02_03.m4a

File info:

General
Complete name : C:\Users\Admin\Desktop\test 2019_01_16_22_02_03.m4a
Format : MPEG-4
Format profile : Base Media / Version 2
Codec ID : mp42
File size : 166 KiB
Duration : 10s 276ms
Overall bit rate : 133 Kbps
Encoded date : UTC 2019-01-16 22:02:14
Tagged date : UTC 2019-01-16 22:02:14
com.android.version : 8.0.0

Audio
ID : 1
Format : AAC
Format/Info : Advanced Audio Codec
Format profile : LC
Codec ID : 40
Duration : 10s 276ms
Bit rate mode : Constant
Bit rate : 128 Kbps
Channel(s) : 2 channels
Channel positions : Front: L R
Sampling rate : 44.1 KHz
Compression mode : Lossy
Stream size : 160 KiB (96%)
Title : SoundHandle
Language : English
Encoded date : UTC 2019-01-16 22:02:14
Tagged date : UTC 2019-01-16 22:02:14

Dependencies require Java11

Project compilation settings specify Java 1.7, but dependencies like ealvalog-java require Java 11

bad class file: /Users/mvmn/.m2/repository/com/ealva/ealvalog-java/0.5.6-SNAPSHOT/ealvalog-java-0.5.6-SNAPSHOT.jar(com/ealva/ealvalog/java/JLogger.class)
class file has wrong version 55.0, should be 52.0

Some tests are skipped and one of them fails

When I run build with Gradle (or Maven support that I've just added in one of the PRs) 1283 tests are run.
But when I run tests in Eclipse IDE on src/test/java folder, 1286 tests are run.

Apparently some tests are skipped by Gradle and Maven - I'm not yet sure why.

I've found out that these two are skipped since they were failing (I've fixed one):

  • FrameBodyUSLTTest - has testWriteUnicodeBody failing, I'm not sure why.
  • AsfHeaderUtils (I know it looks like a util class, but this is in test folder and has methods that are annotated with @Test) - had testConversionDateConstant failing because for some reason the constant was different from the one in JAudioTagger repo. I've fixed that in PR #11

Both of those classes have methods annotated with @Test annotation, but apparently the classes themselves don't get detected as tests by Gradle and Maven.

I can fix that, but I can't fix FrameBodyUSLTTest.testWriteUnicodeBody right now - it seems there is something complicated that has been broken already. This test passes in the original JAudioTagger codebase.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.