earthlinginteractive / oophpdf Goto Github PK

All of the drawable classes, such as MultiCell, tend to require setting up the TCPDF context to get metrics and actually draw the item.

Here is my plan for managing the context:

• When setting up the context, only set properties that were specified by the caller. For example, only set the font size if the caller set a font size on the object.
• After the method that needs to set up the context is done using the context (for example, done drawing), it should restore the context.
• To restore the context, it should revert only the properties that it changed back to their previous values. For example, if before setting up the context the font size was 12 and when setting up the context we set it to 24, it should be restored to 12.

Benefits:

• A TCPDF property that isn't used by the caller behaves the same as a property that isn't implemented in a class. For example, if line-height isn't implemented in the class, we end up drawing with the current line-height in the TCPDF object. If we don't set a font size, a property which is implemented in the class, we end up drawing with the current font size from the TCPDF object. Of course some class properties, like the text of a MultiCell, should have reasonable defaults, such as the empty string, since it isn't a TCPDF property.
• Using one of these drawable classes doesn't affect the TCPDF context. We leave things exactly as we found them, so we play nicely with the rest of the user's PDF writing code.

Run PHP-CS-Fixer to fix coding standards issues.

The Table.php class has two calls to the undefined function getPageRemainingHeight. This should be changed to a new function that calculates the space remaining between the current y position and the bottom margin.

The GitHub README Analyzer only gives your readme an overall score of C. Follow it's suggestions to improve the score.