eclipse-platform / eclipse.platform.releng.aggregator Goto Github PK

Need to create patch build for Java 18 Work done during 4.23 release timeframe

This preparation work involves the following tasks. For previous bug please refer to Bug 577436 - Prep work for 4.23 (2022-03) and open master for development

• #52
• #54
• #57
• #59
• #51
• #67
• #68
• #58
• #81
• #61
• #66
• #62
• #63
• #64
• #72
• #73
• #65
• #75
• #78
• #85
• #93
• #113
• #101
• #107
• #117

I see in Eclipse History that differently to gerrit, where the user that triggered "merge" was recorded as committer, few commits are pushed where the committer is "GitHub [email protected]":

• 3dfa91e
• 004e0b2
• 0299924

Is this something we want / can / should configure globally and document in a policy, or is this responsibility of the individuals to do so, and if yes, hhow it should be done?

See git log --pretty=fuller command output:

git log --pretty=fuller -n 3
commit 02999245b760e4ddb79bd80343277e4828b40fab (HEAD -> master, origin/master)
Author:     Jayaprakash Arthanareeswaran <[email protected]>
AuthorDate: Wed Feb 9 17:37:29 2022 +0530
Commit:     GitHub <[email protected]>
CommitDate: Wed Feb 9 17:37:29 2022 +0530

    Create P-build for Java 18 #7 (#11)

commit 3dfa91e12b724ee6bdb4ab88e106645d81e37b12 (tag: Y20220209-0600)
Author:     Sarika Sinha <[email protected]>
AuthorDate: Wed Feb 9 14:27:28 2022 +0530
Commit:     GitHub <[email protected]>
CommitDate: Wed Feb 9 14:27:28 2022 +0530

    #7 Debug  j18 (#10)
    
    * Update repositories_java18patch.txt
    
    * Update pom.xml
    
    * Update feature.xml

commit 004e0b224f8361da4c6ddf81c09e54aaa099d551
Author:     Kalyan Prasad Tatavarthi <[email protected]>
AuthorDate: Wed Feb 9 13:58:53 2022 +0530
Commit:     GitHub <[email protected]>
CommitDate: Wed Feb 9 13:58:53 2022 +0530

    #7 jdt ui changes for p-build (#9)
    
    * Update repositories_java18patch.txt
    
    * Update feature.xml
    
    * Update pom.xml

Commit f5bf4f1
should be linked to
https://bugs.eclipse.org/bugs/show_bug.cgi?id=578004
but of course there is nothing.

If we now move to github, should we have bugs in github or should link to bugzilla, but just committing without any ticket should be avoided, at least for all non trivial commits.

For example from the latest I-build:

https://download.eclipse.org/eclipse/downloads/drops4/I20220216-1800/download.php?dropFile=eclipse-test-framework-I20220216-1800.zip

If you try to install this in Eclipse you get the "Trust" dialog for mockito and friends due to missing GPG signatures.

I believe this to be caused by a bug in Tycho, see bug eclipse-tycho/tycho#658

Why are we not in the github.com/eclipse namespace like all other projects?

Support for centos has been dropped by Dec 31, 2021. Need to migrate these to use redhat base image version 8.

Code is available here

1. https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/cje-production/dockerfiles/centos-gtk3-metacity/8-gtk3
2. https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/cje-production/dockerfiles/centos-gtk3-metacity/8-swtBuild

Needed in order to start building gtk4 bindings for swt.

Currently we are running smoke tests with Java 11 and Java 17. Need to run these with Java 18 as well

Mockito and AssertJ

Following repos:

• framework
• bundles
• binaries

Here is the list of repositories that needs to be migrated to github. Completed ones will be checked

• #99
• #121
• #25
• eclipse.platform.releng.aggregator.git
• eclipse.platform.releng.buildtools.git
• eclipse.platform.releng.git
• #146
• #149
• #100
• #125
• #123
• #142
• #144
• #103
• #102
• #162
• #161
• eclipse.platform.text.git
• #163
• #176
• #177
• #200
• #201
• #210

Migration Process

(Courtesy @mickaelistria)

Prerequisites
The repo must have very few Gerrit patches pending. Migrating existing contributions from Gerrit to GitHub will be annoying for submitters and reviewers, so we should avoid this as much as possible

Migration steps

1. Request move of repo to GitHub eg https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/891
2. Once GitHub repo is available, go to its settings and customize it. For the moment
   • Disable “Projects”
   • Disable “Wiki”
   • Disable “Merge commits”
3. Once GitHub repo is available, submit PR to aggregator to update submodule URL, eg #19
4. Upon successful completion of the checks, merge the PR. The GitHub repo is now the reference one that’s used to build Eclipse
5. Update CI job to reference GitHub repo, from the Configuration page, replace Gerrit with GitHub. The result looks like this: https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator/jobConfigHistory/showDiffFiles?timestamp1=2022-02-09_10-40-07&timestamp2=2022-02-10_09-55-29
6. Update root pom.xml to reference GitHub repo in tycho.scmUrl property eg eclipse-platform/eclipse.platform.releng#3
7. Update Jenkinsfile for the repo to not include anything related to Gerrit, eg 6de2cdc
8. For the Gerrit repo, create a commit that removes all content and add a file describes the move to GitHub, eg https://git.eclipse.org/r/c/platform/eclipse.platform.releng.aggregator/+/190436 , see https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/tree/ for result. Message in the remaining file should include steps to perform migration, eg

This repository is now moved to GitHub: https://github.com/eclipse-platform/eclipse.platform.releng.aggregator
If you see this message, perform GitHub migration by (assuming the legacy Gerrit repo is called `origin`)
$ git reset --hard HEAD^
$ git remote set upstream [email protected]:eclipse-platform/eclipse.platform.releng.git
$ git pull upstream master

(dot files can/should be removed as well) Do not modify Gerrit repo to not break users (see #24 (comment) )
9 Update https://projects.eclipse.org/projects/eclipse.platform/developer to point to GitHub repo instead of Gerrit one.
10. Send a notification to the project mailing-list + eclipse-dev mailing-list about moved repository.

This Git repository is now moved to GitHub: https://github.com/eclipse-platform/eclipse.platform.releng.aggregator . Please immediately set you `upstream` repo url to use GitHub instead of Gerrit
$ git remote set-url upstream [email protected]:eclipse-platform/eclipse.platform.releng.git

Also update your development files (Oomph profiles, *.psf files...) to adjust your workflow.

11. Close all remaining open Gerrit issues with a message explaining the move to GitHub and how to transition, eg

This repository is now moved to GitHub: https://github.com/eclipse-platform/eclipse.platform.releng.aggregator . Please immediately set you `upstream` repo url to use GitHub instead of Gerrit
$ git remote set-url upstream [email protected]:eclipse-platform/eclipse.platform.releng.git

If you're not planning to continue working on this patch; please mark this current Gerrit review as "Abandoned".
If you're willing to transfer this issue to GitHub Pull Requests:
1. On GitHub Web Interface, fork the repository, and retrieve the URL for the fork eg `[email protected]:my-github-userid/eclipse.platform.releng.git`
2. $ git remote add origin [email protected]:my-github-userid/eclipse.platform.releng.git
3. Checkout this current patch (See the "Download" link on this Gerrit review page)
4. $ git push origin HEAD:refs/heads/a-meaningful-branch-name
5. As output of the push, Git shows a link to Create a Pull Request, follow this link and create the pull request. If some useful discussion took place on Gerrit, you may want to include a link to the Gerrit review on the GitHub pull request message, for reference.

Creating this to track release activities for 4.23. Refer Bug 578869 - Release tasks for 4.23 for bugzilla items

• #115
• #116
• eclipse-platform/eclipse.platform.releng#13
• #111