ecobee / nodejs-gcloud-pubsub-module Goto Github PK

i always got this problem and it made the service to be dead can't respond all the next things

We have run into an issue in our use in a nest microservice where it will fail to close properly in our end-to-end tests where we do manual cleanup of subscriptions.

The chain of events looks like:

• we set up the app
• we create subscriptions and have the module listen to it
• we call app.close()
• we clean up subscriptions on the pub/sub emulator
• because the work in app.close happens asynchronously, in the previous step we inadvertently kill a subscription before the microservice has stopped listening to it
• as a result we get stuck in an endless series of retries in the server's error handler

Have discussed and landed on adding a simple flag to server to represent whether the server is in a "I am trying to close, do not bother me" state, and then not do the subscription close/open activity in handleError if we are in that don't-bother-me-state.

PR to follow.

The current release @ecobee/[email protected] has a dependency to the (outdated) @google-cloud/[email protected] that has a transitive dependency to [email protected]. This version of json-bigint has a security issue with severity high. (see https://www.npmjs.com/advisories/1690)

See output of npm dependency graph:

+-- @ecobee/[email protected]
| `-- @google-cloud/[email protected]
|   `-- [email protected]
|     `-- [email protected]
|       `-- [email protected]

Output of npm audit:

  High            Uncontrolled Resource Consumption in json-bigint              
                                                                                
  Package         json-bigint                                                   
                                                                                
  Patched in      >=1.0.0                                                       
                                                                                
  Dependency of   @ecobee/nodejs-gcloud-pubsub-module                           
                                                                                
  Path            @ecobee/nodejs-gcloud-pubsub-module > @google-cloud/pubsub >  
                  google-gax > google-auth-library > gcp-metadata >             
                  json-bigint                                                   
                                                                                
  More info       https://npmjs.com/advisories/1690 

As there is no newer release of @google-cloud/pubsub with major version 1, it has to be updated to major version 2. (Recent version is 2.17.0) This may contain breaking changes.

The package name is not valid.

npm install nodejs-gcloud-pubsub-module --save

should be

npm install @ecobee/nodejs-gcloud-pubsub-module --save