ecomplus / auth Goto Github PK

After login we should update ecomUtils._config setting at least the correct store_id.

Access token must be private, so user will not be able to pass token when calling ecomClient.store.

We should provide a method to call Store API with authentication (such as requestApi from EcomPassport), imo it can be just a wrapper for ecomClient.store, but already adding the correct storeId, authenticationId and accessToken, something like:

options => ecomClient.store({
  storeId,
  authenticationId,
  accessToken,
  ...options
})

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update commitlint monorepo to v19 (major) (@commitlint/cli, @commitlint/config-conventional)
• chore(deps): update dependency babel-loader to v9
• chore(deps): update dependency husky to v9
• chore(deps): update dependency webpack to v5
• chore(deps): update dependency webpack-cli to v5
• chore(deps): update dependency webpack-dev-server to v5

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Mesma abordagem de ecomplus/shopping-cart#2

BREAKING para v0.5

TODO

• Constructor based JS lib;
• Use @ecomplus/client to consume Store API;
• Take ecomplus-passport-client as example for methods and events;

Suggested TODOs:

• getAuthenticationId: just pass session.my_id 🍰;
• fetchAuthentication: fetch Store API and return respective authentication (current session) body;

We need documentation for lib methods with jsdoc and give some examples 📝

We're exposing session with access token, it's a public property on instance object and it's a problem 💀

My suggestion is to set session object as a private member and pass it as argument to method functions, reference:
https://www.crockford.com/javascript/private.html

Also, we must edit getAuth method (and any other returning access token) to return only my_id, without token.