econclass / cs-2.1-trees-sorting Goto Github PK

Great work on completing these challenges. Here's some feedback to improve your code:

• Your delete_min and get_min() functions are not returning the min element. Use print statements to see why and when this is happening! It is likely due to the incomplete bubble_up/down functions.
• You are missing your priority queue and counting_sort implementations as well! :(

Great job on completing the prefix tree! You can further challenge yourself by working on time and space complexities for each prefix tree method. You would be expected to do this in interviews, and it would be good practice :)

What was great:

• Good job on implementing your is_sorting function efficiently!
• Good job on successfully implementing your sorting algorithms!

Here's some feedback to improve:

• Try adding a couple more test cases! It may seem intimidating at first, but you've made it past the hard part. Implementation is way tougher than calling these functions and comparing inputs. In the work environment, writing tests will be required. Its a good habit to build :)
• Partition should be O(n) and quick_sort is O( n * logn ) because partition loops over the list of length n and quick sort calls it on around half the list based on your chosen partition. In the worst case, it could be O(n**2) if the partition choice is not great!