ed-pavlov / binstate Goto Github PK

Hi,

First of all, thanks for sharing your project. It looks really great.

I had trouble getting started, though. When I use an enum, like one in your example, an enum with value 0 (default) will throw an argument null exception on Builder.DefineState and Config.State.AddTransition. This is a little bit confusing. Could you provide some hint, that 0 on int or enum is also considered null?

Also I think your elevator example might also throw that exception, as the nullcheck is performed on Events, too. At least my enum did throw that exception.

Thanks and cheers!

Hello, there!

As part of the university research we are currently doing regarding the security of Github Actions, we noticed that one or many of the workflows that are part of this repository are referencing vulnerable versions of the third-party actions. As part of a disclosure process, we decided to open issues to notify GitHub Community.

Please note that there are could be some false positives in our methodology, thus not all of the open issues could be valid. If that is the case, please let us know, so that we can improve on our approach. You can contact me directly using an email: ikoishy [at] ncsu.edu

Thanks in advance

1. The workflow build-and-test.yml is referencing action gittools/actions/gitversion/setup using references v0.9.9. However this reference is missing the commit 90150b4 which may contain fix to the vulnerability.
2. The workflow build-and-test.yml is referencing action gittools/actions/gitversion/execute using references v0.9.9. However this reference is missing the commit 90150b4 which may contain fix to the vulnerability.

The vulnerability fix that is missing by actions' versions could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider updating the reference to the action.

If you end up updating the reference, please let us know. We need the stats for the paper :-)

It would be nice to add some mechanics to get next state inside exit action, because FSM behaviour may differs depends on state which transition to. Currently use additional states between my basic states to customize exit action, but it makes code less readable and I think it might be unsafe.

Maybe it could be made by enchancing functionality of IStateController with NextState property and overloading OnExit same as OnEnter

The workflow build-and-test.yml is referencing action gittools/actions/gitversion/setup using references v0.9.9. However this reference is missing the commit 90150b40fdd6c4b06d39cfd764e900cff45ccfca which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.