eddiehubcommunity / eddiehublive Goto Github PK

show date on users on the left bar (user.updateAt.toDate() not working)

Please consider adding a quick start guide.

Description

To enable your contributions to show on the EddieHubLive map events, first a user must submit a request to be included in the data.

To increase the amount of folks who add themselves to the map data and decrease confusion about how the map works, propose to put a link and explanation directly on the map.

Link to be added to the map: https://github.com/EddieHubCommunity/support/issues/new?assignees=&labels=EddieHub-API-add&template=add-api-user.yml&title=Please+add+me+to+the+EddieHub+API

This issue is linked to #58 and should be considered after the UI area to house such information is built.

Screenshots

No response

Additional information

No response

Description

Screenshots

No response

Additional information

No response

If the user has no profile picture on their discord account, display a default picture instead of it

Description

We should add a license to this repository. This way, people will know what and what not they can do with this repository, permissions, notices, etc.. I suggest using the MIT license, however, we can use any other one as well.

Screenshots

No response

Additional information

I believe we should ask all the contributors if they agree to license the repository under a certain license (not 100% sure about that, though).

For audience participation/feedback, it'd be cool if those on the livestream could wave on the stream when the map background is overlaid on your streams @eddiejaoude

just a bit of feedback of who is either there or.... something?

or alternatively it finds out who is actually watching the stream or something?

Dunno? 👋🏻

Description

Events should be descending and have the latest appear at the top

Screenshots

No response

Additional information

when bio is updated, a new pin is added on the map but the old pin isn't removed

Description

• Use json structure from API project
• Send event on demand
• Event to have random data

Screenshots

No response

Additional information

No response

What would you like to share?

To add kubescape actions file to the project

Additional information

No response

What would you like to share?

add linter to enforce formatting

Additional information

No response

Description

While testing, I am noticing some odd behavior. When I first hit the page and edit a comment to produce data, it creates one event card as expected.

All subsequent edits to the comment in this session produce 2 entries.

This happens locally and on the production site.

This is likely a low priority bug as I assume that the way I am using this tool in testing is unlikely to be the way folks are using it during the livestream.

Screenshots

No response

Additional information

No response

Description

When a new event comes in, the page crashes

Screenshots

No response

Additional information

No response

Description

Setup Prettier for formatting the code consistently

Screenshots

No response

Additional information

No response

Description

Currently whenever a new event comes in to the app, the map component rerenders with all of the markers. This does not seem to create any issues and is a common implementation of leaflet in react, however, as an improvement to #66 it would be nice to only zoom to new map contributors instead of potentially zooming to the same person multiple times.

Edit: hold on this issue pending seeing how #66 does live. Perhaps no changes needed depending on UX with more data loading

edit for data

Screenshots

No response

Additional information

No response

Description

Steps to recreate:

1. Browse to live.eddiehub.io
2. Edit an existing comment in an Eddie hub repo to trigger a new event to show on the map
3. Refresh your browser
4. No event data will be displayed

What should happen: As a user of the site, I would expect the current data to persist on browser refresh or close/reopen

TBD: How much data should persist? This is open for discussion. For now, I suggest same day data so that the map is not overwhelmed with entries. In the future, we could create a filter to be able to see different data views.

Whomever takes this ticket, I would also suggest that once the range of data shown is decided that another ticket is created to add something to the UI that clearly indicates what is being shown.

Screenshots

No response

Additional information

No response

Description

The app was created with create-react-app. We want to move to Vite, as it's more state-of-the-art than using Webpack

Screenshots

No response

Additional information

No response

I think this issue happens because you are using old avatar url from Firestore.
https://github.com/EddieJaoudeCommunity/EddieBotMap/blob/584f682704fc50a7071b237b83f81e9183c8892f/src/app/app.component.ts#L71

Does discord provide an event for updated avatars? so you can save the new url.🤔

Or maybe ask users to update their bio after changing the avatar to save the new url. 😁

Description

It would be good to understand the date and time of the event in the event list

Screenshots

No response

Additional information

No response

It would be great to have a screenshot of the map in the README section (even if its not the final version).

Overlapped marker should be replaced with one marker contains total count.
For example:

I found this leaflet plugin that does that Leaflet.markercluster

Description

It would be useful to know what version is deployed, similar to our other apps

Screenshots

No response

Additional information

No response

Description

In checking live.eddiehub.io (production, not locally) I noticed no data in the panel.

In inspection of the network although the websocket connection is 101 as expected, it appears that no data is being transferred.

May be a configuration issue with websockets. See screenshots from the network tab.

Tested in chrome and firefox (latest) on a mac 12.5.1

Screenshots

Additional information

No response

Description

Add instructions for submitting to the EddieHub API and how to initiate new data to fill the side panel.

Info - refine for clarity and tone:

Submit a request here to be added to the API: https://github.com/EddieHubCommunity/support/issues/new?assignees=&labels=EddieHub-API-add&template=add-api-user.yml&title=Please+add+me+to+the+EddieHub+API

After that, open or comment on an issue in the EddieHubLive project to create an entry, edit your comment to create multiple entries

do not keep adding new comments to create data, this will create spam. Editing your existing comment should work for testing purposes.

Screenshots

No response

Additional information

No response

Please upload the project 😁

Description

Side bar currently grows the page, this should have fixed height and also scroll

Screenshots

No response

Additional information

No response

Description

We should run a build validation to make sure we don't merge breaking bugs

Screenshots

No response

Additional information

No response

Description

• Add a description about the Project , how it works and how somebody can use it
• Add Demo Images/GIFs , Link to Live Demo
• Add Contirbution Guide -> Steps to setup Local Development , Steps to Create a PR , Contribution Guidelines
• Add Mock Data for Development - I don't quite understand how GitHub Actions works (some web socket events ig) but I guess it would be better to have some Mock Data while developing the FrontEnd.

Description

When a new event comes in, it would be great to zoom in to the map a bit so the persons pin can be seen better. Then after a certain time, zoom back out to show the whole map again

Screenshots

No response

Additional information

No response

Description

Currently the user is added to the map multiple times (only seen once), this will get slow

Maybe check if the user is on the map already, if so do nothing

Screenshots

No response

Additional information

No response

EddieBotMap should be deployed to GitHub pages, and if possible create a GitHub action that to deploy it 😁

Description

I noticed this project is using Create React App and was wondering if you would be interested in switching to Vite.

Vite has faster builds and is more configurable.

Screenshots

No response

Additional information

No response

Description

Filter out these 3 events

• workflowRun
• checksuite
• checkRun

Screenshots

No response

Additional information

No response

What would you like to share?

As per sharing on Discord, scaling websockets across services requires a lot more work and deployments or any hiccup in network will prevent reconnection.

This would be a good idea regardless of having a "fix" for this problem to reconnect after a 500ms delay to the Live API websocket.

• [] Getting rid of the old poller method for good
• [] Reconnecting after 500ms for any service blips due to deployment

--- a/src/context/socket.js
+++ b/src/context/socket.js
@@ -3,5 +3,7 @@ import { SOCKET_URL } from "../config";
 
 export const socket = io.connect(SOCKET_URL, {
   // WARNING: in that case, there is no fallback to long-polling
-  transports: ["websocket", "polling"], // or [ "websocket", "polling" ] (the order matters)
+  transports: ["websocket"], // or [ "websocket", "polling" ] (the order matters)
+  reconnection: true,

Additional information

No response

Description

npm ci install exact versions in the lock file, it would be good to use the range of versions in the package file for this GitHub Action

Screenshots

No response

Additional information

No response

Description

Currently when a user navigates to eddiehublive, there may be no data.

If there is data and the user refrehes, closes, navigates away and back - the data feed will start over.

This is intended behavior (per discussion in #53 ) but it is unclear to a site visitor.

Proposed UI update:
Add information that shows something to the effect of "Event data live as of XX time". Where the time is based on when the user loads the site.
This could be in a header or at the top of the cards or somewhere else
UI open for discussion

Screenshots

No response

Additional information

No response

Description

I'm not sure if it's meant to have a scrollbar, it it's intentional, feel free to close the issue
I think it shouldn't as the map can zoom in and zoom out and the location sidebar can have a separate vertical scroll

Screenshots

Additional information

No response