GithubHelp home page GithubHelp logo

eddiscoverydata's Introduction

eddiscoverydata's People

Contributors

eahlstan avatar finwen avatar fito-wolf avatar jbhemloque avatar klightspeed avatar nofoollikeone avatar ramonatigier avatar robbyxp1 avatar sirtyler avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

eddiscoverydata's Issues

VoicePack12: List of typos

As they are more than one, I'll start a list:

Line 331: Static say_CrewLaunchFighter $= %(EventClass_Crew) lauched Fighter;Fighter away, pilot %(EventClass_Crew)

must read "launched"!?

VoicePackV17.act line 501

Static say_FSDJumpFaction $= ", System controlled by %rs(EventClass_Faction,say_ss) %ifnotempty(EventClass_FactionState,"in state %(EventClass_FactionState)")"

wouldn't it be better to intercept when the status is "none" and replace "none" with something meaningful?

VoicePackV12.act: Line 285/286 duplicate?

Line:
284 Static say_UIBeingInterdicted $= "%iftrue(EventClass_Interdicted,"Alert Interdiction under way;Warning, being inderdicted, evasive manoeuvres","")"

285 Static say_UIBeingInterdicted $= "%iftrue(EventClass_Interdicted,"Alert Interdiction under way;Warning, being inderdicted, evasive manoeuvres","")"

duplicate, one missing or deliberated?

VoicePackV5 duplicative "Atmosphere" in certain descriptions

V4 output: "... Hot thick carbon dioxide atmosphere."
V5 output: "... Hot thick carbon dioxide atmosphere atmosphere."

Journal entry for an offending scan:

{
  "timestamp": "2017-11-21T09:54:47Z",
  "event": "Scan",
  "BodyName": "Zunoae OC-C c13-3892 A 3",
  "DistanceFromArrivalLS": 385.677429,
  "TidalLock": false,
  "TerraformState": "Terraformable",
  "PlanetClass": "High metal content body",
  "Atmosphere": "hot thick carbon dioxide atmosphere",
  "AtmosphereType": "CarbonDioxide",
  "AtmosphereComposition": [
    {
      "Name": "CarbonDioxide",
      "Percent": 95.84819
    },
    {
      "Name": "Nitrogen",
      "Percent": 3.193114
    },
    {
      "Name": "SulphurDioxide",
      "Percent": 0.958482
    }
  ],
  "Volcanism": "minor silicate vapour geysers volcanism",
  "MassEM": 1.543761,
  "Radius": 6914035.5,
  "SurfaceGravity": 12.871415,
  "SurfaceTemperature": 800.682129,
  "SurfacePressure": 24757328.0,
  "Landable": false,
  "SemiMajorAxis": 370507968.0,
  "Eccentricity": 0.188117,
  "OrbitalInclination": -9.643915,
  "Periapsis": 182.907425,
  "OrbitalPeriod": 3559013.25,
  "RotationPeriod": 3760772.75,
  "AxialTilt": -0.043729
}

As suggested in Discord, the following works well to solve this:
Static say_ScanPlanetAtmosphere $= , %sc(EventClass_Atmosphere) %ifnotcontains(EventClass_Atmosphere, ' atmosphere','')

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.