edheltzel / vscode-1dark-raincoat Goto Github PK

I don't know if this is a serious issue for many, but I've found that the comments' contrast with the background makes them very hard to read and after awhile hurts my eyes. I love this theme, but my only suggestion is to edit the comment colors from the previous value of #5C367085, to remove the alpha channel for a new value #5C3670:

...
"tokenColors" : [
  ...
  {
    "name": "Comments",
    "scope": "comment, punctuation.definition.comment",
      "settings": {
        "foreground": "#5C6370",
        "fontStyle": "italic"
      }
  },
  ...
],
...

It doesn't break the style of the theme, in my opinion, and makes it much more readable due to the increased contrast. Thank you.

Seems to be really red-green heavy, tokens are italicized unnecessarily, etc.

Selection expansion for quotes doesn't works well. It takes quotes inside the selection, while for other blocks like brackets, it doesn't.

Consider changing name to:

• ODRC
• ODRC No Italics
• ODRC Bright
• ODRC Bright No Italics

Sorry. This is not an issue. Just a question.
What is the font you are using in the 1st 2 screenshots:
https://raw.githubusercontent.com/ginfuru/vscode-onedark-raincoat/master/images/js.png

The high contrast version needs to additional workbench styling for peek definition

Could the primary highlight for the 1dark raincoat variants be less bright? It's hard to read red text on bright purple.

Specifically for me, when using the find tab, it's hard to read the selected result in the editor. So when searching for something like "editor", it's hard to see if it's "editor" or "Editor" in text.

https://i.imgur.com/yO7Sf8G.mp4

One Dark Rain Coat should have a better icon

child of #12

The screenshot below has several instances of italicized items that I noticed when opening VS Code this morning, and after disabling/enabling my extensions it seems that onedark-raincoat is responsible for them. Is there any way to disable this? I was unable to find a way to do this after some searching in the VS Code settings.