edicl / chunga Goto Github PK

READ-LINE* currently has no maximum line length, but will instead continue to read input until memory is exhausted. While this default should probably not be changed (there may very well be someone somewhere who is reading multi-gigabyte lines), it would enhance stability to allow callers of the library to specify a maximum line length:

(let ((chunga:*max-line-length* 8192))
  (chunga:read-line* stream))

Would you please consider adding a :description option to your system definition of chunga?

As I understand keywords are never GCed and blindly interning all unknown names can result in massive memory leak. (Especially this relevant for Hunchentoot obviously, but all software based on chunga potentially vulnerable). Personally I like [and propose] this solution https://github.com/deadtrickster/ia-hash-table.

PS. RFC(http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2) states: Field names are case-insensitive AND as-keyword still calls intern for 'known' names with different case

CL-USER> (chunga::as-keyword "User-Agent")
:USER-AGENT

CL-USER> (chunga::as-keyword "User-agent")
:USER-AGENT
:EXTERNAL

so I don't think documentation string for +string-to-keyword-hash+ is correct.