edwardr / staffer Goto Github PK

The Staff post type rewrite is set so that with_front is true. Unfortunately, that means you can get profile links like example.org/blog/staff/person/ because with_front appends the page_for_posts slug to the URL.

I suspect that just changing the plugin would probably break links on existing sites, so it seems that a filter might be the best option here. Happy to submit a pull request.

When you add an audio file / player to the bio content on the backend, it does not display on the frontend because the plugin sanitizes the post content for the data attributes you use to generate the modal window content.

Instead of using a data attribute for the bio content – could you place the complete HTML of the post content in a hidden element to pull from?

Also– it'd be great if we could click anywhere outside of the modal window to close it; not just relying on the small "X" in the upper-right corner.

Thanks!

At present, there is not text representation of each icon. The plugin should load a screen-reader-text class (for now, until universal theme support is better) and provide an accessible icon label in the source.

When making this change, it may also be worth considering whether icons should have persistently visible labels anyway. For instance, the website icon is not particularly clear.

Just like the current settings for the post type name, slug, and archive title, similar options for the Departments taxonomy would be really helpful, particularly the slug.