edwintcloud / cs1.3_exercises

Collection of exercises for course CS1.3 at Make School.

cs1.3_exercises

Collection of exercises for course CS1.3 at Make School.

cs1.3_exercises's Issues

Feedback: First Challenge Submission

Good job on completing the submission! Here are a few things to work on for full credit:

• Binary search: recursive function currently stops before checking the last item in your array! Check your base case to make sure you stop after checking the last item. (You’re only off by one).
• String Algorithms Refactoring: I see that you refactored your contains function. However, find_index and find_all_indexes has duplicate code. Try to refactor it such that there is no duplicate code in your program.
• Missing: Annotations for String Algorithms Time and Space complexity

Feedback on submission 3

• Your medium link is paid. Post a friend link so I can grade it.
• Further challenge yourself by implementing a tree map and/or binary search tree’s delete function.

Feedback on submission 2

Good job on completing the second coding challenge. Here's some feedback to improve:

• Great job implementing a circular buffer. I see that you wrote a couple of ‘tests’ below. Convert that into unit tests —> use assert statements to compare input with what’s expected. This is always good practice for testing code :)
• I noticed that you implemented size as a method. This is fine, but Alan assigned the size to be a property not a method. A property is initialized in init and can be accessed as set.size, while a method is a function call : set.size( ).