edwintcloud / cs2.2-personal-repo

Personal Repo for CS2.2 containing class challenges

CS2.2-Personal-Repo

Personal Repo for CS2.2 containing class challenges

cs2.2-personal-repo's Issues

Challenge 4 Feedback

Challenge 4 Feedback
Overall: 16 /16

Feedback based on Challenge 4 Rubric:
Knapsack Readme 4/4
Knapsack Implementation 4 /4
Other DP Readme 4/4
Other DP Implementation 4 /4

Challenge 5 Feedback

Challenge 5 Feedback
Overall: 20/20

Feedback based on Challenge 5 Rubric:

• Read and Outputs 4/4
• Solves Eulerian ( X 2) 8/8
• Testing 4/4
• Documentation & Organization 4/4

Challenge 1 Feedback

Challenge 1 Feedback : 8/ 20

Overall: Code is a good start, make sure to separate into files for each class (graph.py) for better reuse and add tests and error handling.

Feedback based on Challenge 1 Rubric:

• Works: 4
  • For input of an unweighted graph, it should not output any weights - your code defaults to 0.
• Documentation: 2
  • Add runtime and all parameters to docstrings
  • No attribution given for code copied from tutorial sample (add a line at the top)
  • Create a separate file for the Graph class - for PEP8 Standards
• Code Organization: 2
• use a method for file read code.
• Testing: 0
  • Code does not have unit tests or error handling.

Challenge 2 Feedback

Challenge 2 Feedback : 13/20

Overall: Solid code base. When you add new methods, be sure to add tests for them.

Feedback based on Challenge 2 Rubric:

• Works: (2x 3) = 6

• Runs well when there is a path, but does not run correctly on a graph with an isolated node - should either give path length (INF) or error.

• Documentation: 2

  • Improve your docstrings with parameter and runtime information.
  • No attribution given for code copied from tutorial sample (add a line at the top)
  • PEP8 standards met (a few lines >80 char but otherwise good)

• Code Organization: 3

  • Shortest path is integrated with BFS so does not allow for BFS to be used in another format. Works well for this problem but is not modular for future.

• Testing: 2

  • Good set of base tests and error handling. Add tests for new methods in this challenge find_shortest_path

Challenge 3 Feedback

Challenge 3 Feedback
Overall: 14/24

Feedback based on Challenge 3 Rubric:

• Read & output 3/4
• Graph class 3/4
• DFS 2/4
  • add docstrings to dfs method
  • does not compute the path correctly - you need to store parents of visited vertices and then compute the path from the parents after the recursion is done.
• Code organization 2/4
  • find_path method is doing too much - separate out the dfs, and path computation methods for loose coupling and better future use.
• Testing 1/4
  • Need more tests.
  • Good start on exception handling, but there can be more.
• Documentation 3/4