ehabets / rir-generator Goto Github PK

Hi
I have been using your function before and it was fine, now I have downloaded the latest version, after importing the file using mex like this:
mex rir_generator.cpp
I will receive this error:
Building with 'MinGW64 Compiler (C++)'.
Error using mex
C:\Users\AppData\Local\Temp\mex_723928368179636_15160\rir_generator.obj:rir_generator.cpp:(.text+0x3e3):
undefined reference to `computeRIR'
collect2.exe: error: ld returned 1 exit status

could you please give me some hint about what the problem is?
Thanks
All the best
Niloo

Hi there RIR-Generator!

I was playing around with the RIR-Generator and I noticed that we are allowed to place the receiver coordinates to be outside the room. Are the resulting signals that are being picked up by the receiver accurate despite not being inside the room? If so, is there support for receiving a signal from outside the room parameters? And if not, is there a way to repurpose the code to allow me to pick up accurate audio signals from outside the room?

Thank you!

Is there an interest for a python port for the RIR-Generator?
I am interested in installing it directly from PyPi.
But it would be nice, when the repository, that pushes to PyPi is the original repo.

When there is a chance that a Pull Request would be accepted, I would prepare one.

If I'm following implementations for [0, 1] correctly I believe there are discrepancies between the source code and published equations for the Hanning-windowed ideal low pass filter function.

In rir_generator.cpp:

https://github.com/ehabets/RIR-Generator/blob/master/rir_generator.cpp#L427

LPI[n] =  0.5 * (1 - cos(2*M_PI*((n+1-(dist-fdist))/Tw))) * Fc * sinc(M_PI*Fc*(n+1-(dist-fdist)-(Tw/2)));

However, if I'm following [0, 1] correctly I would expect to be more like the following form:

const double t = (n - 0.5 * Tw) - (dist - fdist));
LPI[n] = 0.5 * (1.0 - cos(2.0*M_PI*t/Tw)) * sinc(2.0 * M_PI*Fc*t)

The notable differences are missing 2.0 * M_PI in sinc, inconsistent t between sinc and cos function, and extra Fc multiplication outside of sinc/cos (although I don't think this matters because Fc = 1.0).

Is this intended to be different than the published equations?

[0] Eq 24 https://github.com/ehabets/RIR-Generator/blob/master/rir_generator.pdf
[1] Eq 1 https://www.ncbi.nlm.nih.gov/pubmed/3782618

The following code does not conform with Equation (24) in the paper

There should be a 2 before Fc in the code .

I think the command
mex -setup **-**C++
should be
mex -setup C++.

Hello RIR-Generator!

Are there plans to support placement of solid objects inside the rooms? Starting with a solid box (same material as wall) of variable size would allow for approximation of "more realistic" rooms with objects in them.

Thank you!

Hello to whom this may concern,
I was trying to apply low pass filters on RIR signals made using this code when I noticed there were aliasing artifacts when I was running the examples from this repo. Is there a reason why for this and is there a way to resolve this?

I attached some .wav files that I made by running some of the example files and using the audio write() function in Matlab in case you wanted to check it as well.
Thank you!
Example_Wav_files.zip