eine / tip Goto Github PK

Since a bundler (webpack) is used now, creation of new release branches is easier. Only four files need to be published (README.md, action.yml, main.js, and main.js.map). Instructions in https://github.com/1138-4EB/tip#development should be updated accordingly. I.e., there is no need to remove items explicitly (git rm -rf *.json *config.js *.lock .github .gitignore __tests__ ts); it should be remove everything except 'dist'.

Got error of ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:2384)

full logs see https://github.com/JoyMoe/OpenData/runs/3917346331?check_suite_focus=true

See https://github.com/stefanzweifel/git-auto-commit-action which does not need a github_token

I have two workflows running. One is the tip release, and another for tagged releases (tagged with a v... tag).

For some reason, the tip release isn't bumped back to the top of the Releases page, making it hard to find. Is there a way to push it back to the top?

I don't understand why. I expect that github is sorting on tag date. But while the tip is shown at the top in my terminal, it's not on the Releases page.

git log --tags --simplify-by-decoration --pretty="format:%ci %d" | head -n 5

2020-03-04 13:39:21 +0100  (HEAD -> master, tag: tip, origin/master)
2020-03-04 13:27:19 +0100  (tag: v1.6.0)
2020-03-04 10:21:24 +0100  (tag: v1.5.0)
2020-03-04 10:13:25 +0100  (tag: v1.4.0)
2020-03-04 09:45:48 +0100  (tag: v1.3.0)

Recently, a couple of repos were added to github.com/actions, which are meant to create and upload/update releases:

• https://github.com/actions/create-release
• https://github.com/actions/upload-release-asset

It might be useful to integrate some features here (e.g. actions/create-release#4, actions/create-release#9, actions/upload-release-asset#4), or hopefully archive this repo in favour of official actions.

Refs:

• actions/upload-release-asset#22
• https://octokit.github.io/rest.js/v18#repos-update-release-asset
• https://pygithub.readthedocs.io/en/latest/github_objects/GitReleaseAsset.html?highlight=asset#github.GitReleaseAsset.GitReleaseAsset.update_asset

Combined with #112, and automated changelogs this can be a nice thing to have. Draft releases with a nighly assets, and release it once ready.

I have a step that auto-generates a changelog. It would be awesome if this action accepted the body to be used for the release, like actions/create-release does.

It would be nice if we could provide the tag name to use. Currently, it's called tip. I would favor a tag latest or nightly instead.

If the tag is configurable, I can even imagine using various cronjobs with different tags.

If there are empty files to be uploaded I get:

2020-07-29T20:55:10.6028756Z · Get GitHub API handler (authenticate)
2020-07-29T20:55:10.6029018Z · Get Repository handler
2020-07-29T20:55:10.6029268Z · Get Release handler
2020-07-29T20:55:10.6029492Z · Upload artifacts
2020-07-29T20:55:10.6379916Z  > artifact/failed/mingw-w64-i686-bison-3.0.4-2.failed
2020-07-29T20:55:10.6380250Z    - uploading...
2020-07-29T20:55:10.6384266Z Traceback (most recent call last):
2020-07-29T20:55:10.6387648Z   File "/tip.py", line 130, in <module>
2020-07-29T20:55:10.6387774Z     gh_release.upload_asset(artifact)
2020-07-29T20:55:10.6388280Z   File "/usr/local/lib/python3.8/site-packages/github/GitRelease.py", line 256, in upload_asset
2020-07-29T20:55:10.6388437Z     resp_headers, data = self._requester.requestBlobAndCheck(
2020-07-29T20:55:10.6389094Z   File "/usr/local/lib/python3.8/site-packages/github/Requester.py", line 333, in requestBlobAndCheck
2020-07-29T20:55:10.6389221Z     return self.__check(
2020-07-29T20:55:10.6389513Z   File "/usr/local/lib/python3.8/site-packages/github/Requester.py", line 342, in __check
2020-07-29T20:55:10.6389632Z     raise self.__createException(status, responseHeaders, output)
2020-07-29T20:55:10.6389999Z github.GithubException.GithubException: 400 {"message": "Bad Content-Length: ", "request_id": "0442:0DFD:62693:78B10:5F21E22E"}

I'd guess this is really rare, so not sure if that needs to be handled..

Related with discussion started here: pypi/warehouse#10234

Assets uploaded without content type specified seem to cause trouble, e.g.:

• SVG graphics fail to display as inline images
• image proxies fail to handle the assets correctly (HTTP 404 in the case described in the above issue)

IIUC, if we could pass somehow the content_type, which is accepted by git release python API (https://pygithub.readthedocs.io/en/latest/github_objects/GitRelease.html), the problem should not appear?

Of course, the question is how to specify it for multiple different files... perhaps automatically by default:

# For MIME types
import magic
mime = magic.Magic(mime=True)
mime.from_file("testdata/test.pdf") # 'application/pdf'

(https://stackoverflow.com/questions/43580/how-to-find-the-mime-type-of-a-file-in-python)