eip-automerger / automerger Goto Github PK

Currently it requires intervention from an editor:

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

Trying to change EIP 1355 state from Draft to Abandoned

I'm not sure this should be required, but can see the pros/cons of both options (having this automatic vs. requiring intervention).

ethereum/EIPs#2400 (comment) attempted to do that, but obviously the automerger has no support for it.

It would be nice though and there seem to be specifications to cover it: https://eips.ethereum.org/EIPS/eip-634

The automerger should attempt to read the vnd.github text record (baed on EIP-634) of an ENS name and compare the github username included in there to the author/approver of the PR.

It seems the automerger is failing on a couple of files as can be seen in: ethereum/EIPs#2040 (comment)

Error checking file EIPS/eip-1485.md
Error checking file EIPS/eip-1895.md

Previous runs failed in more files.

It would be nice to figure out why do exceptions happen.

Proposal:

• include an EDITORS file in the EIPs repo listing the names + github usernames of the editors
• if a PR is approved by an editor, merge it as long as it satisfies the auto-merge requirements (being in draft, etc.)

This would potentially allow more editors to be added without the need for Github access and also simplifies the workload for existing editors.

Here is one example

ethereum/EIPs#1427

Last calls should have a review-period-end set.

Add a check that the incoming ping is coming from https://github.com/ethereum/EIPs only.

In a recent case the automerger was triggered on a fork: vorot93/EIPs#104

Not sure if it is a good idea, but perhaps it makes sense to allow changing files under assets/eip-<N>/ where <N> is the current eip being considered.