ejeschke / glue-ginga Goto Github PK

See https://travis-ci.org/ejeschke/glue-ginga/builds/203503079

This needs more documentation than a README.

The install_requires dependencies found in setup.py of the v0.1.1 release are not compatible with the latest introduction of glue-core. This prevents building the conda package for that version using the recipe found in https://github.com/astroconda/astroconda-contrib

The install_requires list insetup.py as found in master corrects this issue.

When I start a Glue session from the Glue plugin for Ginga, I can drag a file into the window and it appears in the data manager. But when I drag the file to the glue main workspace, the dialog won't let me select any viewer of any kind, including the native 2D viewer. The dialog looks like this:

@ejeschke - would it be possible to add me to AppVeyor so I can control the builds if needed?

Spectrum mode is broken due to refactoring in Glue and needs to be re-implemented.

Follow up to #6 and #10: Use glue_ginga.qt.layer_artist.DataImage (edited) in Glue plugin for Ginga.

A quick attempt in #10 resulted in IndexError. More investigation is needed.

You can see this problem with 2 different workflows.

Workflow 1

1. Open Ginga, start Glue plugin, and launch Glue from plugin.
2. Load a FITS table with column units in Ginga. For example, ftp://ftp.stsci.edu/cdbs/calspec/alpha_lyr_stis_008.fits
3. Send the table to Glue and open it in Table Viewer -- no units!
4. Put it back in Ginga in a new channel -- still no units!

Workflow 2

1. Open Ginga, start Glue plugin, and launch Glue from plugin.
2. Load the FITS table in Glue this time and open it in Table Viewer. Units are still there.
3. Send the table to Ginga -- no units!

Although there is no strong urgency to do so, I wonder whether we should update the required version of ginga in the plugin package. It seems to me that at the very least it would be better to specify a version in the new versioning scheme, which is similar to other packages now.

The latest released Ginga is 2.6.2

I am using dev version of Ginga, Glue 0.11 from pip, and dev verson of glue_ginga. When I press "Start Glue" in the plugin, I get:

Error making callback 'activated': __init__() got an unexpected keyword argument 'maximized'
Traceback:
  File ".../ginga/misc/Callback.py", line 128, in make_callback
    res = method(*cb_args, **cb_kwdargs)

  File ".../glue_ginga/plugins/Glue.py", line 164, in <lambda>
    b.start_glue.add_callback('activated', lambda w: self.start_glue_cb())

  File ".../glue_ginga/plugins/Glue.py", line 305, in start_glue_cb
    self.glue_app = qglue()

  File ".../glue_ginga/plugins/Glue.py", line 378, in qglue
    ga = GlueApplication(data_collection=dc, maximized=False)

I have a vague recollection of adding the maximized keyword myself and this used to work, though I have not used it in a while.

c/c @astrofrog

xref #20 (comment)

Workflow:

1. Start Ginga.
2. Start Glue from Ginga's Glue plugin.
3. Load "ngc6946.fits" (https://stsci.box.com/s/tg6m48hccnmn8jjs3447e0yuillz56ld) in Ginga.
4. Press "Put Data" button on Glue plugin in Ginga.
5. The file is now listed in Glue's left menu but inaccessible.

Traceback (most recent call last):
  File ".../glue/core/application_base.py", line 25, in wrapper
    return func(*args, **kwargs)
  File ".../glue/core/application_base.py", line 197, in add_data
    self.add_datasets(self.data_collection, datasets)
  File ".../glue/core/application_base.py", line 250, in add_datasets
    data_collection.extend(datasets)
  File ".../glue/core/data_collection.py", line 84, in extend
    [self.append(d) for d in data]
  File ".../glue/core/data_collection.py", line 84, in <listcomp>
    [self.append(d) for d in data]
  File ".../glue/core/data_collection.py", line 75, in append
    self._sync_link_manager()
  File ".../glue/core/data_collection.py", line 111, in _sync_link_manager
    for link in d.coordinate_links:
  File ".../glue/core/data.py", line 586, in coordinate_links
    self.coords, i)
  File ".../glue/core/component_link.py", line 317, in __init__
    comp_from = [comp_from[i] for i in self.from_needed]
  File ".../glue/core/component_link.py", line 317, in <listcomp>
    comp_from = [comp_from[i] for i in self.from_needed]
IndexError: list index out of range

The developer version of glue has completely re-written viewers (including the image viewer), so I need to update this plugin to work correctly with the latest version. This issue is to serve as a heads-up that I am aware things are broken, and also that I'll work on it :)

See if anything breaks in Ginga v3 and latest Glue release.

To whom it may concern,

If you are using https://github.com/astropy/ci-helpers in your appveyor.yml , please know that the Astropy project has dropped active development/support for Appveyor CI. If it still works, good for you, because we did not remove the relevant files (yet). But if it ever stops working, we have no plans to fix anything for Appveyor CI. Please consider using native Windows support other CI, e.g., Travis CI (see https://docs.travis-ci.com/user/reference/windows/). We apologize for any inconvenience caused.

If this issue is opened in error or irrelevant to you, feel free to close. Thank you.

xref astropy/ci-helpers#464

I don't think this feature ever took off. Not sure if it even works now. Should we just archive this repo?

What do you think, @astrofrog ?

While this is available under pip, I cannot find it in conda-forge nor AstroConda.

The Ginga viewer for Glue is missing the "RGB" feature to load 3 different mono images from a data set into an RGB image.

This should be straightforward to add, as Ginga supports RGB images.

This is a follow-up to #5.

These are addressed in #10:

• Start Glue in a non-maximized mode (currently hardcoded values are no good for small screen on a laptop).
• Add instructions.
• Make it clear that "Get Data" loads Glue data into the currently active Ginga channel.
• Make it clear that "Put Data" sends the currently active buffer to Glue.
• Enable/disable buttons in a way that is intuitive to users.
• Should we allow plugin to start multiple Glue sessions? (No.) If so, how do we make it stop or send/get data to/from the selected session? (N/A)
• How to handle use case when user terminates Glue outside of this plugin? Note: Add Qt callback for close/quit on q-application. This needs also glue-viz/glue#1168 to be merged and released first.
• Transfer WCS and header from Glue image to/from Ginga.
• How to get/put table data properly?
• How to handle "Close" and "Stop Glue" behavior in an intuitive way?

I'm finally getting back to this, and was thinking it would be great to have a first stable release of this plugin package.

@pllim @ejeschke - are we missing anything that should be included in a first release?