GithubHelp home page GithubHelp logo

Comments (8)

felixbarny avatar felixbarny commented on June 9, 2024

IIRC, we didn't always index all headers. When and why did we change that? Or did we always do that?

from apm-server.

axw avatar axw commented on June 9, 2024

The change was made in #12102. The idea was to align with how we would deal with OpenTelemetry semantic conventions in the future, which would involve dynamically mapping headers.

We could revert to disabling indexing for headers, or switch to flattening them. Either way it's a special case, and not a general solution to avoid hitting field limits.

from apm-server.

felixbarny avatar felixbarny commented on June 9, 2024

Interestingly, that change used the flattened field type for HTTP headers

http.{request,response}.headers have been changed from object to flattened.

Did this change to dynamically indexing as keywords in the context of the apm-data plugin in Elasticsearch?

from apm-server.

axw avatar axw commented on June 9, 2024

@felixbarny sorry, yes, I should have mentioned earlier: I ended up removing that particular use of flattened and switched it to being dynamically mapped to keywords, to match what we would end up doing with OTel.

from apm-server.

felixbarny avatar felixbarny commented on June 9, 2024

Both for OTel and for non-OTel, I think we should use flattened for HTTP headers.

from apm-server.

axw avatar axw commented on June 9, 2024

I think that should be fine. OTOH we've found that using flattened for stack traces is causing problems for ingesting exceptions with huge amounts of source context or deeply nested vars, so we'll probably revert to disabling there.

from apm-server.

axw avatar axw commented on June 9, 2024

elastic/elasticsearch#108227

from apm-server.

axw avatar axw commented on June 9, 2024

We'll also need to bring those changes across to the integration package for 8.15.0. We should be pretty close to switching to apm-data, but I think it may be safer to wait until 8.16.0.

from apm-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.