GithubHelp home page GithubHelp logo

basiccontext's People

Contributors

electerious avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

basiccontext's Issues

Escape data-name

When the title of an item is html, the data-name must be escaped.
ember library mediator

Is this still under development?

Hey there,

It looks like you've built an awesome, easy to use component, but I'm hesitant to use it because it looks like development on it has stalled. There are still features I would like to use that don't appear to have been implemented yet, namely the sub-menu functionality.

So, will development continue for this tool?

Thanks!

New show-function parameters

Current:

basicContext.show(items, e, fnClose, fnCallback)

Proposed:

let opts = {
  onClick,}

basicContext.show(e, items, opts)

Passing the target element down?

From a cursory look at the source code, it seems to me that the element on which the contextual actions are performed is not passed down to the functions that are invoked for menu items.

Is this already possible or would this be a good addition to the library if implemented?

firing a context menu twice has unexpected behavior

repro steps:

1 attach a context menu to an element
2 right click in the element
3 notice that the context menu appears as it should
4 right click again
5 notice that the context menu is still visible, and so is the built-in context menu (see attached screenshot.)

Expected behavior:
If you keep right clicking it will either toggle the visibility of the context menu or it will re-position it under the new mouse position

screen shot 2015-07-06 at 12 08 17 pm

New item options

Remove those options …

let items = [
  { icon: '', title: '', type: 'item' }
]

… and add the following:

let items = [
  { content: '' }
]

// or

let items = [
  { content: () => '' }
]

some ideas

lovely, short written, cool menu, i love it and i love that there is no jquery involved:)
some ideas if you dont mind

  • ability to select where the menu you will show relative to the element, maybe left to it, above it or on top of it, etc..
    • the scroll demo is cool, but the scroll bars are so large and the menu it self is so narrow

all the best and thanks again for simple awesome work :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.