electr0sheep / itemvendorlocation Goto Github PK

Issue : Missing vendor coordinates, one is in lower limsa and one in an instanced (?) ocean fishing area.

Dataset : Internal & Garland Tools
Items affected:
Ragworm
Krill
Plump Worm
Versatile Lure

Merchant & Mender in Limsa Lominsa Lower Decks (X: 3.2 - Y: 12.8)
Merchant & Mender in The Endeavor (X: 6.1 - Y: 6.1)
(Source : https://ffxivteamcraft.com/db/en/item/29717/Versatile-Lure)

Right-clicking any of the chat windows shows the context menu of the plugin to show vendor location.

So far it shows the location of Abyssos Blade and Cracked Anthloclusters.

I think there is a new mechanism for adding context menus. I think the Market Board Plugin has figured it out, and I think it adds a "D" to the entry. I need to implement this.

Love the Plugin, but i have one feature request that i think would make it even better:

Would it be possible to have a Key down option to show all vendors?

For example: If i hold Shift while pressing "Vendor location" it opens the Dalamud popup window with all results, even if "Show only one vendor" option is active.

I'm not sure why this is happening. Best I can guess is that opening a map with "nice" coords like 4.49, 6.11 need to be converted to "raw" coords, and this process is broken for the Wolves' Den Pier map. I have confirmed that the coords are coming over correctly from Garland Tools.

Aenc Ose doesn't have a shop, yet the shop info shows アイテムの購入

The current iteration of the plugin requires you to actually have the item (or search in the marketboard) to get the right-click contextual menu. It would be ideal if there was also a command (say "/vendor [item]) so you can search any item, any time.

Things like Bombard Core and Sacred Spring Water are bought from vendors for Seals and Tomes. Is it possible to add these in so that we can know where to go for these technicality vendor items?

I am probably using CheapLoc in not the best way, and it appears the plugin no longer works for anybody, 🥂 😭

From discord feedback:
Please add the right click vendor location option to items displayed in the raw materials list. Thank you

can you give a json that i can use you plugins

I have a habbit of clicking on player names in chat, and this is when I noticed that [Vendor Location] Option actually gets added to windows that aren't related to Items. For example if you right click on player name in chat to whisper them.

Making this a stand alone issue so it's more clear that this issue exists.
This issue was originally reported in #2

Things like "Scrip Exchange" vendors are found at least in every capital city. Who knows what other vendors there are.

This has got to be the weirdest quest I've ever seen, but when you click on the map location for the quest, it opens a context menu, and the plugin adds the "Vendor Location" here.

So when I use the search option in crafting to find the item "Amateur's Fishing Rod", and select it, under the materials section of the craft when I right click any of the 3 items (Ash Lumber, Ash Branch, or Bronze Ingot), it seems completely random if Vendor Location will appear or not. Sometimes I have to close the right click menu down and right click again up to 5 or 6 times before the Vendor Location option appears. Sometimes its there on the first right click, sometimes the 5th, sometimes the third, sometimes it appears 3 times in a row. Just seems completely random on if it will appear or not.

I don't think any of the items available at the OIC quartermaster are working either

I just had a vendor location appear in the context menu for a person.

Something must have changed, because I'm seeing multiple context menu entries now

Do a vendor search for "Astral Nodule". Only "Luminous Fire Crystal" is displayed, even though 2 other crystals are also required.

I need to do some sidequests to unlock the vendor I think, but there was a report that an incorrect currency was shown for Quinnana

The GC supply mission window does not activate the plugin, even though items can be purchased from vendors

Sells Tin Ore. The map link button isn't doing anything when I click it. Internal data source.

Probably the other things as well, but it shows these as costing
Allagan Tomestone of Casuality x495, Diadochos Sword x0, Diadochos Sword x0

They are purchased with GC seals. In a similar note, it seems like we could get the GC a player is affiliated with and filter the other GC vendor results out.

I need to look more into all of this, but I wanted to leave a quick note for myself.

Please see the attached screenshot for an example:

Weirdly enough, although the location name for that flag is very wrong, the flag is in the correct spot and on the correct map.

18:07:43.775 | ERR Unobserved exception in Task.
System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. (Cannot convert type 'string' to 'ulong')
---> Microsoft.CSharp.RuntimeBinder.RuntimeBinderException: Cannot convert type 'string' to 'ulong'
at CallSite.Target(Closure, CallSite, Object)
at System.Dynamic.UpdateDelegates.UpdateAndExecute1[T0,TRet](CallSite site, T0 arg0)
at ItemVendorLocation.VendorPlugin.<>c__DisplayClass59_1.b__1(Partial i) in /work/repo/ItemVendorLocation/Plugin.cs:line 430
at System.Collections.Generic.List1.Find(Predicate1 match)
at ItemVendorLocation.VendorPlugin.GetVendors(UInt64 itemId) in /work/repo/ItemVendorLocation/Plugin.cs:line 430
at ItemVendorLocation.VendorPlugin.<>c__DisplayClass61_0.b__0() in /work/repo/ItemVendorLocation/Plugin.cs:line 492
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of inner exception stack trace ---
{ } [ Send ]

Set up a hotkey for Vendor Location (Like CTRL+V?) so it can be used with Chat2 as well. When linking an item in Chat2, it doesnt have any plugin options... Gatherbuddy "Gather" also doesnt work with chat2.

Hey, not sure if intended, but it doesn't seem to find vendors for Wolf Marks items. I was looking at Makai Fists that are sold for 4000 Wolf Marks.
Thanks for the plugin, it's neat!

I understand this is brand new and in testing so hopefully, this helps out.
I'm having several issues, perhaps all related.

1st. Nothing appears to happen on some items that have Vendor Buy prices when clicking on Vendor Location menu most of the time. See 2nd issue.

2nd. When clicking on Sort/Unsort which generally appears for me just above Vendor Location, on an item that can be bought, it does work. Okay, further testing showed some items work in the Armory clicking Vendor Location others I have to click sort/unsort to get the vendor list. What items do work using Vendor Location? Skysteel Hatchet, Softstepper's Turban, Custom Made Robe of Casting, and a few others which can be bought at the Calamity Vendor. What doesn't work? lots of other equipment that can be bought OR crafted. This could be the same in inventory/retainers as well.

3rd. Doesn't seem to work for Gemstone Vendor stuff. I'm guessing this is a different system but should prob state in the description it doesn't.

Feel free to msg me on discord for more info. I'm in the Goat discord. can dm me from there.

I can only seem to get this to work on the marketboard.
It does not work when selecting the item from your inventory

Links to Husting strip were linking to merchants strip

Was running a dungeon and I noticed a reproducible frame rate drop when I was using spells/abilities. I was able to reproduce just sitting in my room casting stuff. I believe it's tied to this plugin, and the frame rate drop is incredible, dropping from 200+ frames to like 15. This sucks and I have to figure it out for sure. Luckily, the stuff I have released doesn't seem to suffer from the same severe drop, but I'm pretty sure I'm still seeing a bigger drop than I'd expect.

After the net6 updated, the DalamudApiLevel is dictated by DalamudPackager, so all you need to do is update DalamudPackager.
If you do specify an DalamudApiLevel in the json, it will override the API Level from DalamudPackager.

Currently, when Garland Tools sends me unexpected data, the plugin simply does nothing other than generate an unhandled error message in the logs. I need to handle this and display a message letting the user know that they should send feedback and state the name of the item they are searching for so I can actually fix it.

Dont think they should be there xD

The vendor Location only shows "No Location" on all items. I have just freshly installed this plugin for the first time if that matters.

The script exchange vendors don't have a specific "shop" listed. This would be quite nice to have.

It would be nice to have collectables exchange items handled as well.

Specific example, "Weaver's Gobbiegoo" (30325). This is needed for weaver skysteel relic, but it's not clear how to get it. Garland Tools also does not have any data for it. Would be great if the plugin pointed you to Denys, and that "Oddly Specific Cloth" (531106) is required.

It shows deltascape instead of the alchemsts' guild in Ul'dah.

I have a fix, but I'm very curious as to how this NPC got mapped to deltascape.

Thank you for your recent support of other languages.
I will report what I noticed after using.

This is a partial excerpt.
Sylphic Vendor
😁Undyed Linen "East Shroud (22.4 ,26.4)" 411 Gil
😱Undyed Linen "East Shroud (22.4 ,26.4)" 1 Sylphic Goldleaf

Sahagin Vendor
😁Night Milk "Western La Noscea (17.0 ,22.5)" 84 Gil
😱Night Milk "Western La Noscea (17.0 ,22.5)" 1 Rainbowtide Psashp

Vath Stickpeddler
😁Mythrite Nugget "The Dravanian Forelands (23.7 ,19.1)" 2376 Gil
😱Mythrite Nugget "The Dravanian Forelands (23.7 ,19.1)" 1 Black Copper Gil

Luna Vanu
😁Birch Sap "The Sea of Clouds (7.1 ,14.3)" 468 Gil
😱Birch Sap "The Sea of Clouds (7.1 ,14.3)" 1 Vanu Whitebone

If there is a sale of the same item with gil and tribal money,
Tribal money products do not have map and flag responses.
In addition, maps and flags are displayed for items that can only be bought with tribal money.
I hope this problem is resolved.

I initially thought that this is item or one vendor specific but I have noticed a bunch of vendors defaulted to coordinates like (11.5,11.6) in cities or close to it and around (21.9,21.8) for merchants & menders outside cities. I uninstalled and re-installed the plugin but the issue remained. Sometimes the flags show nothing or are off the map completely.

These are all examples....the issue seems to be with vendors and guild suppliers...but also seems to have extended to merchants & menders that sell various leveling gear etc.

So far, I've walked around in Ul'dah to the Sapphire Venue Exchanged, checked an item of each vendor's location and found that the coordinates are wrong.

I am unable to get the drop down menu to extract when searching for vendor locations, the arrow button does not let me interact with it.

I tried to use it in the JP version FFXIV.
But nothing happens when I select the context menu.
garlandtools.org supports FR/DE/JA item names, although you need to switch..
Will it be possible to respond in Japanese in the future?

I'm pretty sure it doesn't filter out items with no vendors. So, if you search for something that doesn't have any vendors, the plugin will say something like "3 results found for [item]", but not list anything. I think that's confusing. I could either say no results found, or I think a better option would be to acknowledge the items exist, but they don't have vendors.