GithubHelp home page GithubHelp logo

Comments (4)

kevinsawicki avatar kevinsawicki commented on July 20, 2024

I made a tweak in 41248d7 for this. It just looks for assets with atom-shell in the release.

Do you think that is sufficient?

from grunt-download-electron.

simtel12 avatar simtel12 commented on July 20, 2024

It probably is. That said, I'm a fan of making big rename changes as obvious as possible, since it tends to break other scripts too; which is why in my pull request for the rename, I created a new task and made it incompatible with the older versions'

This gets the job done though, and at the end of the day that is the most important thing. Thanks. 👍

from grunt-download-electron.

kevinsawicki avatar kevinsawicki commented on July 20, 2024

That said, I'm a fan of making big rename changes as obvious as possible

Yeah, I was planning on renaming both the package and task, but grunt-download-electron was already taken and I was reaching out to the author.

from grunt-download-electron.

kevinsawicki avatar kevinsawicki commented on July 20, 2024

Yeah, I was planning on renaming both the package and task, but grunt-download-electron was already taken and I was reaching out to the author.

The repository and task have now been renamed and published as 2.0.0

from grunt-download-electron.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.