Comments (4)
I made a tweak in 41248d7 for this. It just looks for assets with atom-shell
in the release.
Do you think that is sufficient?
from grunt-download-electron.
It probably is. That said, I'm a fan of making big rename changes as obvious as possible, since it tends to break other scripts too; which is why in my pull request for the rename, I created a new task and made it incompatible with the older versions'
This gets the job done though, and at the end of the day that is the most important thing. Thanks. 👍
from grunt-download-electron.
That said, I'm a fan of making big rename changes as obvious as possible
Yeah, I was planning on renaming both the package and task, but grunt-download-electron
was already taken and I was reaching out to the author.
from grunt-download-electron.
Yeah, I was planning on renaming both the package and task, but grunt-download-electron was already taken and I was reaching out to the author.
The repository and task have now been renamed and published as 2.0.0
from grunt-download-electron.
Related Issues (19)
- Explain why rebuild is needed HOT 7
- Format for filename changed? HOT 2
- v0.8.0 fails to install atom-shell < v0.13.0 due to missing 'arch' in release filename HOT 1
- spawn ENOENT on OSX HOT 11
- use node-pre-gyp + npm HOT 2
- Fatal error: CERT_UNTRUSTED HOT 5
- Not downloading atom-shell HOT 5
- Cannot unzip under windows with node v0.11.x
- cannot find atom-shell in download-atom-shell task
- download fails because repository changed atom/atom-shell to atom/electon HOT 4
- Rebuilding native modules breaks the asar module. HOT 5
- Task creates Atom.app, should it be Electron.app? HOT 2
- "Cannot find electron v0.22.1 from GitHub null" 'warning' HOT 4
- Unable to dowload a 64 bit version for a Windows 64 bit machine HOT 1
- Cross-platform downloads HOT 2
- Atom / Debian issues HOT 1
- Atom Shell downloaded as non-executable HOT 2
- Download broken for latest (v0.13.0) atom-shell release HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grunt-download-electron.