elegant996 / scgi-transport Goto Github PK

First, thanks for writing this module! I think for some users (I know one) your work will finally put Caddy on par with Nginx.

Right now the module expects the response to begin with headers:

The format of the response is not specified by this protocol.

It practice, SCGI server implementation like the Wapp web framework often respond with a status line first (like HTTP/1.1 200 OK), which makes them incompatible with the module. Could you handle this case?

This is just an FYI, we've recently merged some changes that will land in v2.4.0 that change a bit how you should invoke the Caddyfile unmarshaler for the rpHandler.

caddyserver/caddy@e4a22de#diff-6672fa0777d0d187809940a7d14eadf14ad36e4206c77f19822c67b668f1084c

In particular, you should add this bit of code after rpHandler.UnmarshalCaddyfile(dispenser)

	err = rpHandler.FinalizeUnmarshalCaddyfile(h)
	if err != nil {
		return nil, err
	}

This makes the new handle_response feature parse correctly.

(As an aside, just out of curiosity, what do you use SCGI for? What language/scgi server do you use it with? I've never used the protocol myself)