GithubHelp home page GithubHelp logo

recoil-vscodium-theme's People

Contributors

ellacrity avatar

Watchers

 avatar

recoil-vscodium-theme's Issues

Remove conflicting rules and make overriding easier

I created this theme because I wanted something unique that fully utilized VSCodium's ability to provide semantic token highlighting. I have found that most popular dark themes lack proper contrast to be able to differentiate between UI components, barely(?) meet WCAG guidelines for accessibility, and are very bland. I am not a fan of the general washed out look that most dark themes tend to have.

Although I created the theme simply for my own use, now that it is public and published to the extension repository, I feel a bit of a sense of obligation to correct the issues this project has.

The main problem with this project, as I see it, is the lack of maintainability. I did not plan for there to be a few thousand lines of color directives. As such, I kind of just added, changed and removed things as I went until I liked it a bit better. After many iterations, it has become a bit of a mess.

I would like to clean up the main theme config file, removing duplicate entries and conflicting rules. For example, textmate rules tend to be far more precise, but they are overridden by "editor.semanticTokenColorCustomizations". This is a problem, because it is very difficult to tell when a rule will actually be applied or whether it will be overridden.

This issue will remain open until the repository is in a proper state. A non-exhaustive list is as follows:

  • Duplicate entries should be removed
  • Conflicting rules removed and replaced with textMate rules when possible
  • Consider building a parser and generator
  • Begin documenting changes in the CHANGELOG.md

Suggestions are welcome. If anyone uses this theme and would like to help out, I would greatly appreciate it. Thank you!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.