GithubHelp home page GithubHelp logo

Comments (4)

ellisonleao avatar ellisonleao commented on May 26, 2024 1

yeah, the error highlights for treesitter are kinda odd, specially on errors, this is a known bug which i am hoping to fix in the next few days.

from gruvbox.nvim.

ellisonleao avatar ellisonleao commented on May 26, 2024 1

hey @pianocomposer321 ive changed the hightlight with an underline and red bold fg. Unfortunately treesitter still highlights some elements inside the original error msg and you will still see those in a different color. LMK if that makes sense.

from gruvbox.nvim.

timbedard avatar timbedard commented on May 26, 2024 1

@ellisonleao And now I'm running into the deviation from OG gruvbox in all other uses of Error. 😂

  1. I vote we revert the Error highlight group to again match OG gruvbox.

  2. If I understand correctly, TSError highlights where Treesitter encountered a parsing error, not where there is an error in the code or where some symbol in the code is of an Error type, so it's a bit of an oddball as far as highlight groups go.

For myself, unless I'm actively working on a Treesitter parser, I don't care if it ran into a parsing error, especially given Treesitter's ability to recover and parse the rest of the file. I would much rather let it fail silently and have some words look off than light my code up like a Christmas tree.

I think the better approach here would be to link it to something unobtrusive or just not bother defining the highlight group for TSError.

from gruvbox.nvim.

pianocomposer321 avatar pianocomposer321 commented on May 26, 2024

Looks much better, thanks!

from gruvbox.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.