Comments (6)
Hm, there was this fix...
from browser.
Hmm that fix was for hashes right?
from browser.
I guess it would need the same fix of parsePath instead of parseHash. Gonna try to create a PR.
from browser.
@alfonsogarciacaro I've created a unit test that passes (w/ or w/o the check in line 357) when running in CLR, which tells me the substring
impl in JS doesn't work the same way as String.Substring
- JS throws exception if start position points at the end, while .NET - returns empty string. Do you think this should be addressed in Fable core?
from browser.
will release a fix in urlParser 1.0.1.
from browser.
@et1975 The substring implementation seems to be right in Fable (it will return an empty string if startIndex is same as length). Maybe the error is caused by something else?
from browser.
Related Issues (20)
- Naming conflict with the new Fable.Browser.XXX packages HOT 3
- Fable compilation error "A unique overload for method 'TryParse' could not be determined..." HOT 12
- 3.0.1 not on nuget (needed to fix #22) HOT 3
- TypeError: 对象不支持此操作 (object does not support this operation) HOT 7
- ToNavigable hides non-navigation message names from debugger HOT 2
- add Parser.pathUrl HOT 6
- How to parse multiple query parameters HOT 1
- Uncaught Error Thrown in Routed Elmish Applications HOT 5
- Base64 string padding char seems to trip up parser HOT 3
- Fable.Elmish.Browser broken after Fable.Browser.Dom update HOT 2
- Fable Compiler 3 Fails to compile HOT 2
- TryParse' could not be determined based on type information prior to this program point HOT 2
- Should we handle the onChangeRef differently? HOT 2
- How to notify the user that the Parser module has been moved to its own pacakge? HOT 3
- Fix for Fable substring behavior for v4 HOT 1
- Elmish.Navigation.Program.Internal.unsubscribe doesn't unsubscribe HOT 4
- Problems with Fable 4 HOT 1
- Tracers.console not working HOT 1
- Calling `Navigation.newUrl` from the `init` user function does not trigger a call to `urlUpdate` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from browser.