GithubHelp home page GithubHelp logo

MapInit error about browser HOT 6 CLOSED

tforkmann avatar tforkmann commented on August 30, 2024
MapInit error

from browser.

Comments (6)

et1975 avatar et1975 commented on August 30, 2024

Hm, there was this fix...

from browser.

tforkmann avatar tforkmann commented on August 30, 2024

Hmm that fix was for hashes right?

from browser.

tforkmann avatar tforkmann commented on August 30, 2024

I guess it would need the same fix of parsePath instead of parseHash. Gonna try to create a PR.

from browser.

et1975 avatar et1975 commented on August 30, 2024

@alfonsogarciacaro I've created a unit test that passes (w/ or w/o the check in line 357) when running in CLR, which tells me the substring impl in JS doesn't work the same way as String.Substring - JS throws exception if start position points at the end, while .NET - returns empty string. Do you think this should be addressed in Fable core?

from browser.

et1975 avatar et1975 commented on August 30, 2024

will release a fix in urlParser 1.0.1.

from browser.

alfonsogarciacaro avatar alfonsogarciacaro commented on August 30, 2024

@et1975 The substring implementation seems to be right in Fable (it will return an empty string if startIndex is same as length). Maybe the error is caused by something else?

from browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.