GithubHelp home page GithubHelp logo

javascript's People

Contributors

emadmri avatar

Watchers

 avatar

javascript's Issues

No CSS file

You forgot to make a CSS file to style the HTML document.

Using var instead of let is causing problems

In this function, you have used var to declare 'img' instead of let. Due to this, the 'img' is available globally. Now, if you see on line 125, you have appended the 'img' to body element after already appending it the li element. But each element can have only one parent, hence the 'img' is removed from the li element and is added to the body. Therefore, when your loop will run successfully, the last 'img' in the data would be added to the body instead of the li element.

If you had used let instead of var, the scope of the 'img' would have been limited to the loop and the statement on line 125 would have given an error (which you can check on the console in the web browser).

javascript/week4/script.js

Lines 117 to 126 in 2673456

function Covers(data) {
for (let key in data) {
var img = document.createElement("img");
img.setAttribute("src", data[key]);
img.setAttribute("alt", key);
let id = document.getElementById(key);
id.appendChild(img);
}
document.body.appendChild(img);
}

Only one image added

You have added just one image and duplicated it for others as well. This way, you won't be able to add images to elements having ID other than 'mind_for_number'.

javascript/week4/script.js

Lines 104 to 115 in 2673456

bookCovers = {
"mind_for_number" : "http://t0.gstatic.com/images?q=tbn:ANd9GcQ4iPYgAFssn-DGcttvY5oz_wrKzw4Bp819Zfx4FSff1AzWZD4i",
"mind_for_number" : "http://t0.gstatic.com/images?q=tbn:ANd9GcQ4iPYgAFssn-DGcttvY5oz_wrKzw4Bp819Zfx4FSff1AzWZD4i",
"mind_for_number" : "http://t0.gstatic.com/images?q=tbn:ANd9GcQ4iPYgAFssn-DGcttvY5oz_wrKzw4Bp819Zfx4FSff1AzWZD4i",
"mind_for_number" : "http://t0.gstatic.com/images?q=tbn:ANd9GcQ4iPYgAFssn-DGcttvY5oz_wrKzw4Bp819Zfx4FSff1AzWZD4i",
"mind_for_number" : "http://t0.gstatic.com/images?q=tbn:ANd9GcQ4iPYgAFssn-DGcttvY5oz_wrKzw4Bp819Zfx4FSff1AzWZD4i",
"mind_for_number" : "http://t0.gstatic.com/images?q=tbn:ANd9GcQ4iPYgAFssn-DGcttvY5oz_wrKzw4Bp819Zfx4FSff1AzWZD4i",
"mind_for_number" : "http://t0.gstatic.com/images?q=tbn:ANd9GcQ4iPYgAFssn-DGcttvY5oz_wrKzw4Bp819Zfx4FSff1AzWZD4i",
"mind_for_number" : "http://t0.gstatic.com/images?q=tbn:ANd9GcQ4iPYgAFssn-DGcttvY5oz_wrKzw4Bp819Zfx4FSff1AzWZD4i",
"mind_for_number" : "http://t0.gstatic.com/images?q=tbn:ANd9GcQ4iPYgAFssn-DGcttvY5oz_wrKzw4Bp819Zfx4FSff1AzWZD4i",
"mind_for_number" : "http://t0.gstatic.com/images?q=tbn:ANd9GcQ4iPYgAFssn-DGcttvY5oz_wrKzw4Bp819Zfx4FSff1AzWZD4i",
};

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.