Runtime error with @alias in service about ember-decorators

[rwjblue]

@NullVoxPopuli - Ya, I reached out to @wycats to double check the spec with me also. Hopefully will have a more definite confirmation in a couple days...

[buschtoens]

Apparently transform-decorators-legacy works a bit differently and does not replace the original property, but instead calls defineProperty on top. At least that's what I reckon at a quick glance.

The obvious quick fix is jumping through the codebase and replacing all offending code:

  @alias('session.data.authenticated.id') id,
  @alias('user.name') name

  // becomes

  @alias('session.data.authenticated.id') id: null,
  @alias('user.name') name: null

[rwjblue]

I am going to close this for now. The version of decorators that we are currently using (with babel-plugin-transform-decorators-legacy) is from the original proposal. The babel crew are actively working on updating for the current spec and hopefully we can migrate to that soon enough. When we do, we will re-evaluate these sorts of issues...

[NullVoxPopuli]

Here is my babel config in ember-cli-build:

    babel: {
      // ember < 2.13 / babel < 6
      // optional: ['es7.decorators'],
      // ember >= 2.13 / babel >= 6
      plugins: [
        'transform-decorators-legacy',
        'transform-decorators',
        'transform-object-rest-spread'
      ]
    },

[rwjblue]

@buschtoens - Thank you chiming in here! That definitely seems like a reasonable solution for folks blocked by this. I'll need to read through the spec a bit more to see if the behavior babel@6 + transform-decorators-legacy is exhibiting is correct or a bug...

[NullVoxPopuli]

oh man. that would be a hefty change for me. I use the decorators everywhere.
Thankfully, I'm not blocked, as this 2.13.1 upgrade is branched.

I know I can regex-replace all of them -- but lemme know if the non-object notation is gonna be the final one (the current notation ( @alias('property') aliasedProperty ) )