Comments (6)
Extending IntlService
and overwriting private property _locale
could be used as a workaround:
import BaseIntlService from 'ember-intl/services/intl';
import { tracked } from '@glimmer/tracking';
export default class IntlService extends BaseIntlService {
@tracked _locale = 'en';
}
Maybe _locale
should default to a default value specified in intl configuration?
from ember-intl.
What I didn't understand from your description, though, are:
* What issue(s) you encountered because `en-us` is present * Why you set `_locale` to `'en'` (i.e. which public API did you need that depends on the value of `_locale`?)
Can you explain the issue(s) to me, maybe from the perspective of your end-users?
I don't think it's causing a bug from end-user perspective. I only noticed in a test, which ensures that the list of locales shown in language selector is in sync with the list of translations existing in the project. The language selector is not using IntlService.locales
as the source of truth to render the options in the language selector. So no bug from end-user perspective.
from ember-intl.
Hi,
we hit the same bug, and it was visible to the end user. We used the IntService.locales
property as source of truth and we had some custom logic to choose the locale based on the browser language from the list of available translations (= IntService.locales
).
In short, for language that did not have an exact match, we choose another one so that for "en-us" we would choose the "en-gb" translations.
Now there is an exact match for "en-us" the app tries to use "en-us" and then shows "missing translation" texts.
from ember-intl.
Hi, @jelhan. Thanks for reporting a bug and providing a minimal reproduction. In your repro app, I could see that en-us
is added by default. (My guess is, perhaps as a fallback when a translation is missing.)
At the moment, due to another issue with ember-intl@v6
around TypeScript, I get the impression that we'll want to rethink about ember-intl
's API and implementation, and whether there are ways to simplify them. (That is, it may take me a while.)
What I didn't understand from your description, though, are:
- What issue(s) you encountered because
en-us
is present - Why you set
_locale
to'en'
(i.e. which public API did you need that depends on the value of_locale
?)
Can you explain the issue(s) to me, maybe from the perspective of your end-users?
from ember-intl.
This also seems related: #1826
except this crashes the app.
from ember-intl.
I have a possible fix in #1847, but it requires a breaking change in the test helper setupIntl()
. If the fix is correct, the change would be made in [email protected]
.
from ember-intl.
Related Issues (20)
- Double `intl.d.ts` cause type errors HOT 8
- A simple, autogenerated integration test fails for a component using a translation in ember-intl 6.1.2 HOT 6
- Bundle size regression in v6.2.0 HOT 3
- Merge this into formatjs HOT 3
- Incompatible with native `ember-source` types HOT 5
- `allowEmpty` class property not respected in v6.3.1 HOT 1
- Extending helpers like FormatDate has braking changes between v6.2.2 and v6.3.0+ HOT 5
- Basic usage results in: You attempted to update `_locale` [...] infinite revalidation bugs, and performance issues, and is not supported. HOT 4
- How to use `publicOnly: true` in Embroider apps HOT 13
- v6 - Error on valid use of `many`: message cannot be parsed: Unknown plural category: many HOT 1
- Deleted
- Plans for v7 release
- Memory leak regression after upgrading to `>= 6.3.0` HOT 3
- Do not blow up the whole page if a variable is missing ? HOT 2
- Vulnerability in dependency `glob-parent` via `broccoli-merge-files` HOT 10
- Create a docs-app that checks `wrapTranslationsWithNamespace: true`
- Create a docs-app that checks fetching translations HOT 1
- Create a docs-app that checks `publicOnly: true`
- Could not find module `eventemitter3` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-intl.