Ability to convert Ember.Evented usage about ember-lifeline

[mehulkar]

Something explicit in the readme would be ok too. I think using registerDisposable is a fine way to convert usage.

[mehulkar]

Or add a function like this:

/**
 * Ember Lifeline provides some primitives to dispose off event handlers bound to Ember.Evented
 * objects. This helper puts them together allowing the user to cleanly add and remove
 * listeners in the lifecycle of the listener.
 *
 * @function addEventedEventListener A helper to use ember-lifeline with Ember.Evented
 * @param {Object} listener The `this` context from where this is called
 * @param {Object} target The target that triggers the event name, that we want to listen to
 * @param {String} eventName The name of the event to bind the event handler to
 * @param {Function} handler A reference to the event handler
 */
export function addEventedEventListener(listener, target, eventName, handler) {
    const boundMethod = bind(listener, handler);
    target.on(eventName, boundMethod);
    registerDisposable(listener, () => target.off(eventName, boundMethod));
}

usage:

addEventedEventListener(this, this.get('myService'), 'someEventName', this.handler)

[mehulkar]

ping @scalvert @rwjblue

[scalvert]

Hey @mehulkar, thanks for opening this discussion. Sorry for the delay in getting back to you; I was delayed in responding while processing what this means/would look like.

I'm open to having some API that we interact with that allows us to track usages of Ember.Evented's APIs, but am not entirely sure what that should look like. I'm not convinced that we should overload the addEventListener implementation to work for both DOM and Evented events. This feels a bit odd to me, and I can't quite put my finger on why yet.

I'll start exploring what this could look like. Meanwhile, I'm curious what @rwjblue thinks.

[scalvert]

Just doing a bit of cleanup on issues in this repo. If this issue is closed in error please reopen!