Framework objects look to be included in undestroyed objects when using setupLifelineValidation about ember-lifeline

[scalvert]

This is definitely an issue with internal destroyables. One thing to note is, the setupLifelineValidation helper was intended to ensure that consumers had correctly setup runDisposables when they were using lifeline. This helped ensure there was continuity between the associated APIs. Now that we use the destroyable functionality, we no longer need to call runDisposables, and hence no longer really need setupLifelineValidation.

[rwjblue]

@snewcomer - What version of ember-source? Also, just FWIW, the updates done in #852 do mean that all destroyables would assert (not just ember-lifeline objects).

[snewcomer]

Seeing this on two apps at 3.20.4.

Certainly seems like a really important assertion. Do you think we will have less issues on future 3.22 release? If not, any ideas how I can go about finding the source of these? I tried prying but didn't lead me anywhere.

[rwjblue]

Can you provide a repro that I could dig into?

[snewcomer]

If this streamlined destroyable API is an internal implementation of this library (destroyables from the user point of view are "just handled" now), do you think this test helper has validity for users? Is it rather something for the library to assert it has wired up the destroyables correctly?

I'll see if I can come up with a repo tonight.

[rwjblue]

@snewcomer - The ultimate goal is for @ember/test-helpers or ember-qunit itself to make the assertion, but internally since we migrated to the newer implementation we wanted to be able to avoid duplicating all the code.

FWIW, I am specifically referring to https://github.com/emberjs/rfcs/blob/master/text/0580-destroyables.md#assertdestroyablesdestroyed.

[snewcomer]

@rwjblue Here is a repo with two rendering tests - acceptance test passes, integration test fails. Both render the same glimmer component. Note in the apps I work on, there were undestroyables in acceptance tests.

https://github.com/snewcomer/destroyable-lifeline-bug

[nlfurniss]

Also seeing this is our internal app (3.20.6) after upgrading this addon to the latest version: hundreds of “undestyroyed” objects (mocks in tests, tracking payloads, Ember objects, etc).

[scalvert]

I think we can dust off @snewcomer's repo and work from there.

[nlfurniss]

I changed the version of Ember in Scott's repro - tests pass, then they fail after 3.20.2

3.18.1 ✅
3.20.0 ✅
3.20.1 ✅
3.20.2 🔴 <<<< Update Glimmer rendering engine to 0.54.2. Fixes an issue with (private for now) destroyables work to enable the destroyables polyfill to work more appropriately.
3.20.6 🔴
3.24.4 🔴
3.27.x 🔴