GithubHelp home page GithubHelp logo

Comments (4)

scalvert avatar scalvert commented on May 22, 2024

Hmmm, I wonder if we need to return settled() in that function.

export function pollTaskFor(token) {
  assert(
    `You cannot advance pollTask '${token}' when \`next\` has not been called.`,
    !!queuedPollTasks[token]
  );

  run.join(null, queuedPollTasks[token]);

  return settled();
}

It'd be a bit weird to import test helpers stuff into prod code, but such is life when you expose testing functionality in a module.

@rwjblue - thoughts?

from ember-lifeline.

rwjblue avatar rwjblue commented on May 22, 2024

Seems "fine"ish...

from ember-lifeline.

scalvert avatar scalvert commented on May 22, 2024

Unconvincing response...

from ember-lifeline.

rwjblue avatar rwjblue commented on May 22, 2024

hahaha, indeed!

from ember-lifeline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.