GithubHelp home page GithubHelp logo

Comments (2)

BryanCrotaz avatar BryanCrotaz commented on May 22, 2024

Doesn't leak:

  _openHandler() {
    if (this.onOpened) {
      run(() => {
        schedule('sync', () => {
          if (!this.isDestroyed && !this.isDestroying && this.onOpened) {
            this.onOpened(this, this.url);
          }
        });
      });
    }
  }

Leaks:

   _openHandler() {
    if (this.onOpened) {
        scheduleTask(this, 'sync', () => {
          if (this.onOpened) {
            this.onOpened(this, this.url);
          }
        });
    }
  }
...
  destroy() {
    runDisposables(this);
 
    this.close();
    this.onOpened = null;
    this.onClosed = null;
    this.onError = null;
    this.onMessage = null;

    this._super();
  }

from ember-lifeline.

BryanCrotaz avatar BryanCrotaz commented on May 22, 2024

I think the cancelId is being left in the registeredTimers array once the scheduled execution is complete. This is a problem for long lived objects.

from ember-lifeline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.