Comments (6)
@viniciussbs #950 implemented exactly that :)
from ember-template-lint.
I think there is a tad more nuance here. As I don't think that <button {{action 'foo'}}></button>
itself is bad, it is only bad when contained within a <form>
, right?
from ember-template-lint.
it's bad for fastboot and for e-reader that might tell the use it's a submit button instead of just a button
from ember-template-lint.
for fastboot, you'll get button the will refresh the page instead of doing nothing until the JS catch
from ember-template-lint.
I was here searching for a rule like "button-type-attributes", similar to the existing one "img-alt-attributes", that would require the presence of the attribute type
on <button>
to avoid wrong form submission. I didn't know that this is also a problem even outside form tags. For me it's OK to always enforce the presence of type
.
from ember-template-lint.
I'm starting to work on this one
from ember-template-lint.
Related Issues (20)
- `no-implicit-this` + strict mode false positives HOT 13
- gjs/gts w/ Input component erroneously reports errors about `builtin-component-arguments`
- Simple-unless not Allowing Unless Inside an Else Statement
- `no-invalid-interactive` recommendation can break navigation shortcuts for SR users
- `no-invalid-link-text` error with handlebars `aria-label`
- `attribute-indentation` fails HOT 1
- Improve README organization
- `<li role="presentation">` should not cause `no-invalid-role` HOT 3
- embedded templates indented incorrectly
- embedded templates using single quotes instead of double quotes HOT 4
- Incorrect no-redundant-role warning on input HOT 2
- Should we start a Polaris config that folks can opt in to when using gjs/gts? HOT 4
- Embedded templates incorrectly violate `no-trailing-spaces` rule
- New rule: `simple-modifier` HOT 7
- Is there a way to have the codemod format only the component that's being fixed and not change the format of unrelated components? HOT 1
- ember-template-lint doesn't support plugins exposed using an exports field in package.json HOT 1
- Add `--cache` so that ember-template-lint can be fast on large projects HOT 1
- template-lint "no-partial" trips up when partial is passed as param
- false positive on no-whitespace-for-layout HOT 2
- Block-indentation Reports Same Value for Start and End Location
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-template-lint.