Option to throw on error in `visit` about ember-cli-fastboot-testing

[CvX]

I like it. If an error is thrown on the backend side of ECFT, it should be re-thrown on the test frontend.

[ryanto]

Hey @thec0keman thanks for the issue.

I'd love to hear more about this idea! How are you currently using this in your tests?

[thec0keman]

Sorry for the delay in responding.

We currently are building a test suite for our fastboot conversion. Our current plan is to take our suite of acceptance tests, and adapt a sub-set of them to also test against fastboot.

While starting this, it became clear right away that testing the DOM results could be difficult for developers since the visit helper always passed. However, if we throw on an error, it makes the test perform more consistently.

This is an example test:

      // Network mock

      const result = await visit('/home');

      if (result.err)
        throw result.err;

      assert.exists('.nav-header');

[ryanto]

Interesting!

My expectation would be that if visit errored here then assert.exists('.nav-header') would fail since fastboot wouldn't have rendered the html. Is there a case where visit errors but HTML is still rendered?

[ryanto]

Hey @thec0keman I'm going to close this issue since it might have gone stale. Feel free to reopen!