Testing for redirects behaves differently in local tests vs. CI about ember-cli-fastboot-testing

[ryanto]

Thanks for the report!

Something feels off if local and CI have two different results. We've got no tests in here for redirects, so I think a first step is getting these status codes tested in this addon.

Do you mind sharing how you're doing redirects in your app?

[jonnygreen]

Sure, the route uses the redirect hook...

// app/routes/posts/index.js
export default Route.extend({

    ...

    redirect(model) {
        this.replaceWith('posts', model.firstPostId);
    }
});

The test is then run against the posts index route...

// tests/fastboot/index-redirect-test.js
test('it redirects to the first post', async function(assert) {
    let { htmlDocument, statusCode } = await visit('/posts/');
    assert.equal(statusCode, 200); //returns 307 in Circle CI

    ...
});

Let me know if I can help more.

[ryanto]

Awesome, thanks!

I did a little digging and it looks like fastboot responding with 307 for replaceWith is the correct behavior. Here's the test case in the FastBoot repo: https://github.com/ember-fastboot/ember-cli-fastboot/blob/master/test/fastboot-location-test.js#L94-L115

Just to be safe, I added some redirect tests into this addon's test suite as well: #8

If your local environment and CI are having different results you might want to confirm that both environments are running the same version of FastBoot.

If it's still causes issues for you, do you mind creating a new repo where we can see this bug in isolation? That way we can see what it will take to fix this upstream in fastboot.

[ryanto]

Closing for now, but feel free to reopen!

[jonnygreen]

Thanks Ryan

I've tried running the test suite for ember-cli-fastboot-testing locally. I now get the same redirect test failures as I was experiencing in my own app i.e. running the test locally for me actually performs the redirect and then runs the test on the resulting page:

Obviously, I'm running the same versions as specified in the package.json, so the only variable I can think remaining is node - could this be a node version issue? Locally, I'm running 8.9.1. My CI tests are running 8, though I can't discover the point version.