GithubHelp home page GithubHelp logo

Comments (10)

CvX avatar CvX commented on July 20, 2024

Raising the limit sounds good! The default 100kb is definitely too low for many reasonable cases. 🙂

I wouldn’t expose bodyParser options to ECFT users. It’s an implementation details that could change (e.g. if we move communication from http to web sockets).

from ember-cli-fastboot-testing.

KalachevDev avatar KalachevDev commented on July 20, 2024

@CvX Agreed! Would you like me to raise PR with these changes?

from ember-cli-fastboot-testing.

CvX avatar CvX commented on July 20, 2024

Yeah, that would be great! 😃

from ember-cli-fastboot-testing.

ryanto avatar ryanto commented on July 20, 2024

Yup, totally agree!

from ember-cli-fastboot-testing.

KalachevDev avatar KalachevDev commented on July 20, 2024

Opened #79

from ember-cli-fastboot-testing.

ryanto avatar ryanto commented on July 20, 2024

Hey @KalachevDev you mentioned you're using ember-cli-fastboot-testing with ember-cli-mirage. I'd love to hear about how you've set that up?

from ember-cli-fastboot-testing.

CvX avatar CvX commented on July 20, 2024

I’m also using mirage factories with ECFT. It’s something along those lines:

import { module, test } from 'qunit';
import { setup, visit, mockServer } from 'ember-cli-fastboot-testing/test-support';
import noteFactory from '../../mirage/factories/note';

module('FastBoot | notes list test', function(hooks) {
  setup(hooks);

  test('it has the correct page title', async function(assert) {
    let note = new noteFactory().build();
    await mockServer.get(hostname, '/api/note/1', { note });

    let { htmlDocument } = await visit('/notes/1');

    assert
      .dom('head title', htmlDocument)
      .hasText('A test note');
  });
});

from ember-cli-fastboot-testing.

KalachevDev avatar KalachevDev commented on July 20, 2024

@ryanto sure! @CvX we do a bit different:
Created such helper: https://gist.github.com/KalachevDev/e192dc68769803da22a5412b7af602d2
And use it following way in tests:

await mockServer.get(urlToPassToMirage).resolve()

from ember-cli-fastboot-testing.

ryanto avatar ryanto commented on July 20, 2024

Awesome, thanks!

This was released as version 0.0.17

from ember-cli-fastboot-testing.

KalachevDev avatar KalachevDev commented on July 20, 2024

Thanks, @ryanto

from ember-cli-fastboot-testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.