emiln / stalmanu Goto Github PK

This closes #11 and #12 as they are no longer relevant.

Inspired by re-frame it would be cool to try out their emit and handle flow. Basically you can only communicate over the internal channels by calling

(emit! :message {:user "..." :channel "..."})

and handle this event by creating a handler for the topic :message:

(handle :message
  (fn [json] "..."))

which will (for every matching handler) be passed any arguments beyond this first from the call to emit!.

The client will currently emit! topics of type String, like "message". The only reason it isn't emitting the more idiomatic keyword type is laziness. It would be very easy to convert the limited range of Strings used by Slack to keywords.

Something along these lines:

(fn [string]
  (-> string
    (clojure.string/replace #"_" "-")
    (keyword)))

This will facilitate multiple word filters acting independently and is a prerequisite for #1.

The full rant takes up a great deal of space in the chat. It would be nice if Stalmanu only responded in full every few minutes and used a slightly less verbose rant for any necessary reminders between the full rants. I suggest the following:

• He may rant at length if he hasn't done so for 5 minutes.
• His short rant reads: It's GNU+Linux.

The rapid progress of Stalmanu has left most docstrings rather outdated. This should be fixed, and particularly for stalmanu.client where many important functions reside.

By interjecting using postMessage instead of over a websocket, it's possible to format the message using attachments, which should make it much more pleasing to read. Stalmanu's long rant would definitely benefit from this.

While Stalmanu's effort to correct improper use of Linux without paying proper homage to GNU is applaudable, he is only scratching the surface of improper word usage. I think he should be extended to cover the most obviously software-centric terms on this list.

Slacker is already using clojure.tools.logging so it would make sense to hook into this to log relevant events to disk.

With the release of Slacker 1.2.0 to Clojars, Stalmanu should really be updated.

They look really ugly as strings.