emilybache / yatzy-refactoring-kata

Starting code for a Refactoring Code Kata on the Yatzy rules

Support this and all my katas via Patreon

Yatzy Refactoring Kata

There is a top code kata video explaining why you might want to try this refactoring kata. The original exercise was designed by Jon Jagger and is available in his Cyber-Dojo. See his blog post. I have changed it a little, so that the rules more closely match what I'm used to.

If you like this Kata, you may be interested in my books and website SammanCoaching.org

Kata Description

The problem that this code is designed to solve is explained here: Yatzy

Contributing to this Kata

Please do not send me your refactored solutions. I am however grateful for language translations and updates to dependencies.

I recently added new refactoring challenges to the Java version and I would appreciate translations of Yatzy2 and Yatzy3 in other languages.

Code Reading Practice

Test your code reading skills. Here is a description of what to do: Scanning for Code Smells. There are suitable lists of urls to open in some of the language subdirectories.

yatzy-refactoring-kata's Issues

Provided Ruby file fails tests for versions >= 2.7

The provided ruby code and accompanying tests won't pass for recent versions of Ruby.

$ ruby test_yatzy.rb
test_yatzy.rb:1:in `require_relative': --> ~/Yatzy-Refactoring-Kata/ruby/yatzy.rb
_5 is reserved for numbered parameters
    1  class Yatzy
>  86    def initialize(d1, d2, d3, d4, _5)
>  93    end
  256  end
.... # similar errors elided for brevity

This is because the provided file follows the convention of the original problem, and uses underscore number in variables names: _1, _2 etc.

Since Ruby 2.7 (released 2019), numbered parameters have been reserved in the language as default block parameters.

This means that, in order to get passing tests to start the refactor in currently supported versions of Ruby, you need to rename these variables.