Comments (4)
from starlette.
And when I change media_type of JSONResponse to "application/json; charset=utf-8", this issue solved
This is not true. The charset
set doesn't solve anything.
from starlette.
From muxacarin provided sample code, the two endpoints have different response just because of calling json.dumps
without pass ensure_ascii=False
.
And when I change media_type of JSONResponse to "application/json; charset=utf-8", this issue solved.
Adding charset=utf-8
is not intended to make both endpoints respond the same.
The problem is if starlette do not provide charset=utf-8
explicitly, some client cannot parse response correctly. dart http library is the one. It would use latin1, if charset is unknown.
from starlette.
From muxacarin provided sample code, the two endpoints have different response just because of calling
json.dumps
without passensure_ascii=False
.And when I change media_type of JSONResponse to "application/json; charset=utf-8", this issue solved.
Adding
charset=utf-8
is not intended to make both endpoints respond the same.The problem is if starlette do not provide
charset=utf-8
explicitly, some client cannot parse response correctly. dart http library is the one. It would use latin1, if charset is unknown.
Ah. Got it!
I've been reading around, and I understand why we don't send the chatset=utf-8
on application/json
. The reason is that JSON already assumes UTF-8: https://datatracker.ietf.org/doc/html/rfc4627#section-3.
Since that's the case, I think HTTP clients that don't make this consideration should be in the wrong.
Thanks for the help here.
from starlette.
Related Issues (20)
- SystemError when using gradio==4.12.0 with starlette>=0.30.0 on Python3.8 HOT 1
- Drop `python-multipart` dependency
- Warn users if setting too large of a session object
- Typing error for app.add_exception_handler (Argument "handler" to "add_exception_handler" of "Starlette" has incompatible type) HOT 1
- TrustedHostMiddleware raises RuntimeError on sending response to websocket HOT 2
- typing map _RequestData in testclient.py might be missing type bytes HOT 2
- Enable `branch = true` for `coverage.run` HOT 4
- Fetching API docs occasionally fails at starlette framework middleware issue with streaming large responses
- links on the release-notes not found. HOT 1
- Add `Partitioned` cookie attribute HOT 2
- `RuntimeError("No response returned")` in `BaseHTTPMiddleware` HOT 3
- Incompatibility with anyio v3
- TestClient DeprecationWarning with httpx 0.27.0 HOT 4
- Bug: `_TemplateResponse` is still relying on `request` key from `context` which maybe different from `request` argument to `TemplateResponse`. HOT 4
- How to change the value of request body?
- A `RuntimeError: Stream consumed` error is raised when `request.body()` is read in the custom middleware
- CORSMiddleware always add access-control-allow-credentials regardless of Origin
- ValueError when null byte in URL HOT 2
- responses.py - appears UTF incompatible (Line 58 and probably other places)
- Double path unquote inside _TestClientTransport.__init__ method
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from starlette.