GithubHelp home page GithubHelp logo

Comments (4)

Kludex avatar Kludex commented on May 31, 2024

MRE: #2340 (reply in thread)

from starlette.

Kludex avatar Kludex commented on May 31, 2024

And when I change media_type of JSONResponse to "application/json; charset=utf-8", this issue solved

This is not true. The charset set doesn't solve anything.

from starlette.

neolooong avatar neolooong commented on May 31, 2024

From muxacarin provided sample code, the two endpoints have different response just because of calling json.dumps without pass ensure_ascii=False.

And when I change media_type of JSONResponse to "application/json; charset=utf-8", this issue solved.

Adding charset=utf-8 is not intended to make both endpoints respond the same.

The problem is if starlette do not provide charset=utf-8 explicitly, some client cannot parse response correctly. dart http library is the one. It would use latin1, if charset is unknown.

from starlette.

Kludex avatar Kludex commented on May 31, 2024

From muxacarin provided sample code, the two endpoints have different response just because of calling json.dumps without pass ensure_ascii=False.

And when I change media_type of JSONResponse to "application/json; charset=utf-8", this issue solved.

Adding charset=utf-8 is not intended to make both endpoints respond the same.

The problem is if starlette do not provide charset=utf-8 explicitly, some client cannot parse response correctly. dart http library is the one. It would use latin1, if charset is unknown.

Ah. Got it!

I've been reading around, and I understand why we don't send the chatset=utf-8 on application/json. The reason is that JSON already assumes UTF-8: https://datatracker.ietf.org/doc/html/rfc4627#section-3.

Since that's the case, I think HTTP clients that don't make this consideration should be in the wrong.

Thanks for the help here.

from starlette.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.