Comments (8)
Hey, if this one is still up for grabs I would like to take it.
from encore.
Hey @pksieminski @eandre
Since secrets list
already pretty much does everything listed here apart from reporting an error, I was wondering if it makes sense to instead add a flag to the list command eg:
list --compare-envs=prod,dev
(or whatever flag name makes more sense eg. --report-inconsistent ...)
which would then additionally exit with an error.
I know it would not be as explicit as having a separate check
command but just wanted to bring it up.
Let me know what you think.
from encore.
Actually, now looking at what you initially wrote:
General idea is to use this new command in GitHub Workflows, which would allow us to check PR before merge if all secrets for development and production environments are properly set in Encore.
Does it then even make sense to provide environments as arguments since judging by the requirement we always want to compare dev <-> prod environments ?
from encore.
The desired behavior isn't really about comparing environments. It should accept a list of environment types and report whether any secret doesn't have a value for any of the provided environment types. (If no environment types are provided it would default to check all environment types)
from encore.
Ok makes sense, but still, the reason I am asking is as far as I know (correct me if I am wrong), currently there are only two environment types as defined here ?
So the only possible combination is dev prod ...
I get it if we want to cover future cases where we would have more environment types but I do hope you see my confusion?
Thanks
from encore.
No, secrets can be configured for four different environment types (local, PR envs, dev, and prod). See https://encore.dev/docs/primitives/secrets
from encore.
Now it makes more sense ;)
from encore.
Hey, I submitted a PR
from encore.
Related Issues (20)
- Javascript generated client triggers errors on User-Agent in browser HOT 2
- encore run auto-reload doesn't change the old Process ID
- 1.15.0 is released but does not get installed by the installation script HOT 1
- Fatal error when running in debug mode HOT 3
- Can't decode query parameters to pointer types HOT 1
- Optional query parameter being sent as 'undefined'
- An unhandled panic occurred in the Encore compiler: runtime error: index out of range [3] with length 3 HOT 3
- Parser error: prob recursion HOT 4
- Install Encore CLI on Windows with scoop HOT 1
- error running encore app HOT 1
- Proposal: graceful shutdown improvements HOT 2
- Flow doesn't show databases for `sqldb.NewDatabase(...)`, only for `sqldb.Named(...)` HOT 1
- encore run panic
- Typescript generated client type error with slice optional query parameters HOT 1
- Support for other cloud providers HOT 4
- Having no tests causes the build to fail. HOT 5
- Compiler error is misleading when migrations folder is missing.
- metrics: panic handling request: runtime error: index out of range [1] with length 0
- Support optional params and enums in OpenAPI client generation HOT 3
- Support async authDataGenerator in generated typescript client HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from encore.