Having no tests causes the build to fail. about encore

[eandre]

I believe real issue is not that there were no tests, but that there were no Go packages:

$ mkdir foo && cd foo && go mod init example.com

$ go test ./...
go: warning: "./..." matched no packages
no packages to test

$ echo $?
1

Whereas if you have a package:

$ echo "package foo" > foo.go

$ go test ./...
?   	example.com	[no test files]

$ echo $?
0

I'm not sure why Go made the distinction to treat "no matching packages" as a test failure; I guess to avoid mistakes. I believe if you have a matching Go package without tests Encore won't treat the tests as failing.

All that said, maybe Encore should treat this scenario as failing the build, and not just the tests? The "One or more tests failed" error is certainly confusing.

[MatthewJamesBoyle]

hmm I did have a go package though:
.

However if I delete the test file now and re-run the build it does pass. Let me try and repro on a new project. Maybe I did something else wrong.

[MatthewJamesBoyle]

Ok I reproed this.

• I ran encore create app
• I created a project called "testing-no-tests"
• I selected blank project.
• I created a package as follows:

• I ran git push encore
• The deploy failed: https://app.encore.dev/testing-no-tests-tv9i/deploys/staging/147po86agipf5vipittg with the same error:

[eandre]

But did you actually commit the thing/thing.go file? I believe the error you're seeing only happens when there are no Go packages.

[MatthewJamesBoyle]

Aha I'm not sure I did :) will close!