engelsen / instrument-control

MATLAB Instrument Control

Instrument-control

The repository contains various MATLAB objects for controlling instruments (from command line and from GUIs), recording and saving data traces with metadata, and for interactive data analysis.

For more detailed information please refer to the project Wiki

Dependencies

The software is tested with MATLAB 2019b. Additional toolboxes required:

• Most instrument classes use Instrument Control Toolbox

• MyFit classes need Curve Fitting Toolbox and Signal Processing Toolbox

• The control class for HighFiness wavelengthmeters needs MATLAB Support for MinGW-w64 C/C++ Compiler

instrument-control's Issues

Add Gaussian fit to MyFit

Create first version of MyFit

• Automatically generated GUI based on fit parameters
• Subclass for each fit? Lorentzian, Gaussian, Exponential etc? Maybe too much..
• Plots both the fit and the fit function with initial parameters
• Fits can be put in MyTrace objects

Make better GUI for MyNa

• Make a full GUI similar to what exists for MyRsa, such that all properties of the NA can be seen and controlled by the user.

Error when empty trace is passed to reference

Currently in MyDaq, when an empty trace is passed from the Data trace to the Reference trace, there is an error. When MyTrace tries to plot this empty trace, it gives an error as it attempts to check if the line object is a child of the main_plot.

Improve GUI position of edit boxes to render faster

Also set visibility to 1 only at the end of rendering

Write documentation for MyFit

Implement Lakeshore as a MyInstrument subclass

Implement save function for MyTrace

Sliders for changing initial conditions of fit in MyFit GUI

• After fitting, set initial conditions to fit parameters, then allow user to change them with sliders in the GUI

Make GUI optional for MyInstrument

Trace loading function for MyTrace

Quick export function in MyTrace

Maybe export to png and put image in clipboard?

Write documentation for MyRsa

Write documentation for:

-[] MyRsa
-[] MyNa
-[] MyTrace
-[] MyScope

Scaling of fit parameters does not work if one is zero

Currently, if a fit parameter is zero, the sliders cannot be used to change it as they merely apply a multiplicative scaling.

Save fit button for MyFit

Create a saveFit button for MyFit that allows saving of the fit parameters and maybe also xf/yf and x/y? Can save the whole thing as a .mat

Set appropriate access settings for properties and methods for MyFit

Make GUI for MyNa

Make GUI following the RSA model, or maybe adapt Mohammad and Amir's GUI for automatic ringdowns, then change the plotting axis to be General Plot rather than its own window.

Add Lorentzian fit to MyFit

Implement auto ringdown with the MyNa object

Resolve whether to use interfaceobj or driver for scope

Drop down menu to change fit

Change the top title to a dropdown menu that allows changing the fit

Fix edit_Callback function for MyFit such that fit_params can have more than a single char

Issue: Currently, fit_params can only be a single character as the callback function uses tag(end) to edit fields
Suggested solution: Search for _ which delineates the end of the generic part of the handle name and the start of the unique tag.

Currently MyFit takes inputs in the form of MyTrace, make it possible to give inputs as [x,y] also

Make find hline function

The code for finding hlines should be made into a class function

Set appropriate access settings for properties and methods for MyInstrument

parseInputs default setting

The function would currently empty the x and y vectors in addition to resetting the other options. Functionality should probably be changed so that even with the default flag on it would not reset x and y.

Change baseDirCallback to use uiputfile

For input sanitization.

Find solution for passing information between MyInstrument objects and GPlot

Set appropriate access settings for properties and methods for MyTrace

Create continuous read function for MyScope

Create first version of GPlot

• Retain functionality from current General_Plot
• Start the other objects from General_Plot GUI

If fit window is closed it stays in Fits cell of MyDaq

If a fit window is closed, the deleted object stays in the Fits cell of MyDaq. Need to create a deleted event for MyFit where the listener removes the deleted object from the Fits cell.

Set appropriate access settings for properties and methods for MyDaq

Add convenience features relating MyFit object to vertical cursors in GPlot

• Plot initial conditions in axis handle, update when vertical cursors for that object are moved (put Callback in Vertical Cursors to update the MyFit objects that are under GPlot

Create arithmetic functions for MyTrace

Arithmetic should check if units are the same, and if so, allow arithmetic with the traces where x is overlapping. Can interpolate linearly to create the correct number of points, but should give warning if this happens.

Set appropriate access settings for properties and methods for MyInstrument subclasses

Modify to utilize MyTrace capability of plotting in the same hline

Remove hline_init property from MyFit and instead use MyTrace plot functionality

Add analyze button to GUI that does the fit

Should also trigger the NewFit event.

Vertical cursors give errors unless there is a buttonup/down fcn for window

If there is no WindowButtonUpFcn and WindowButtonDownFcn defined for the main window of MyDaq, the VerticalCursors give an error. Currently, there is a callback that does nothing. Needs to be investigated.

Improve rendering performance of GUI

Consider:

Leonardo, I will consider this for a future release. The following changes would be made to uix.mixin.Container:

• Define a property RedrawMode to control whether or not to redraw
• In set.Dirty, add a condition to redraw only if RedrawMode is 'on'
• In set.RedrawMode, when setting to 'on', redraw if dirty (see onFigureChanged)
  I see that you are using a VBox full of HBoxes. Would a Grid work for you?

These are suggestions to make it render faster from GUI layouts creator.

Display fitted parameters and QOL parameters from MyFit (e.g. quality factor)

Write documentation for MyScope

Add Exponential fit for MyFit

Should provide Q

Find better solution for valid_points in MyRsa

Currently valid point numbers are hard coded in MyRsa. Once functionality is extended to other RSAs than Tektronix 5103 and 5106, this should be removed.

Current initial parameters for exponential fits do not work with negative numbers

Modify initParamGaussian to work with negative data values.

Menu for instruments: Callback creates correct MyInstrument object. Adds listener for NewData event.

Create a delete function for MyFit

Delete function for MyDaq is not linked to the GUI

Write delete function that works properly and properly cleans up MyDaq

Write documentation for MyTrace

Write documentation for MyNa