GithubHelp home page GithubHelp logo

enginehub / worldeditcui Goto Github PK

View Code? Open in Web Editor NEW

This project forked from mumfrey/worldeditcui

236.0 14.0 44.0 1.41 MB

WorldEdit client interface for Minecraft, running on Fabric

License: Eclipse Public License 1.0

Java 100.00%
minecraft worldedit visualization fabricmc fabric worldeditcui hacktoberfest

worldeditcui's Introduction

WorldEditCUI

Actions Status

A graphical user interface for WorldEdit. WorldEditCUI is designed to assist in using WorldEdit, as well as preventing accidental errors.

Please note that this is not WorldEdit, which allows you to make changes to your world, but WorldEditCUI, a frontend for WorldEdit. You must have WorldEdit installed on your server.

This version of the mod is for Fabric, but a LiteLoader version is also available.

Installation

  1. Install Fabric
  2. Install this mod into Minecraft mods folder

WorldEdit selections will be shown without any configuration necessary, but the colours used are configurable when Mod Menu is installed.

Compiling

Run ./gradlew build

To import the project into your IDE, see FabricMC Wiki article and start from Step 3.

Misc

You can subscribe to updates either by watching this project, or by joining the EngineHub Discord guild. Support questions belong in the #worldedit-cui channel.

Wait, EngineHub owns this repository now?

Yes, the original owner @mikroskeem agreed to move it under our ownership.

Credits

Legal stuff

The code for WorldEditCUI (and therefore the compiled mod) is licensed under the Eclipse Public License v1.

worldeditcui's People

Contributors

aurorasmiles avatar bloodmc avatar cyilin avatar earthcomputer avatar ecconia avatar guntherdw avatar ivan-khar avatar james090500 avatar jochembroekhoff avatar kurtdoedel avatar lahwran avatar mazdallier avatar md-5 avatar me4502 avatar mikroskeem avatar mumfrey avatar octylfractal avatar prplz avatar renezeidler avatar ruviolence avatar startforkiller avatar wizjany avatar x00la avatar yetanotherx avatar zml2008 avatar zubiden avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

worldeditcui's Issues

Cylinder selection on Y 0 is not rendered right.

WorldEditCUI Version

1.18.2

Fabric Version

0.13.3

Fabric API Version

0.48.0

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

I was trying to fill in a cylindrical wall, but as soon as I expanded my area down below Y 0 (that just happened to be the level of my superflat world), it renders like the selection is only one block heigh. If I use the set command, it shows that the area is in fact selected correctly

Expected Behavior

Selection would render as worldedit has selected it. Starting at Y 0, and ending at a different Y level

Reproduction Steps

  1. Set your selection mode to cyl
  2. Select an area starting at Y 0 and ending at a different Y value

Anything Else?

2022-05-08_19 47 47

Various issues with shaders

I'm using the SEUS PTGI E9 ray tracing shader pack but the colors don't work when I use that pack:

image

Without the shaderpack it works:
image

I'm guessing this must be an issue with every shaderpack? I want to be able to use the shaderpack though while also using WorldEdit CUI. Just not sure if this is something that the shaderpack needs to fix or if it's something WorldEdit CUI needs to account for.

1.18.x release

The Problem

It seems like this mod is compatible with 1.18.x (#53 implies that imo) so I think an actual release with a mod would be helpful.

A Solution

Create a release for 1.18.x.

Alternatives

Explain the current state of the mc/1.18 branch.

Anything Else?

No response

1.15.1 update

Changes what I haven't figured out yet:

  • GameRenderer#renderCenter is gone
  • MinecraftClient#init is gone
  • GuiLighting class is gone

Move to MatrixStack and RenderLayer-based rendering

Minecraft seems to be trying to move away from immediate-mode rendering -- parts of the game have been converted already, others are yet to be converted.

While we can continue using the old way of rendering for now, I expect new major versions of the game to make that harder and harder, so it's probably a good idea to explore switching the CUI over whenever someone has time, rather than doing a rushed conversion right before a MC release.

Crash on joining in world/server

The game crashed whilst unexpected error
Error: java.lang.NoSuchMethodError: 'void com.mojang.blaze3d.systems.RenderSystem.glMultiTexCoord2f(int, float, float)'
Fabric, 1.17.1

Worldedit just stopped woring double slash command is invalid

WorldEditCUI Version

WorldEditCUI-1.18.2+01

Fabric Version

0.10.2 for 1.18.2

Fabric API Version

0.48.0

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

Whenever I enter the double slash command (//) I get (Unknown or incomplete command, see below for error at position 1: /<--[HERE]) as an error.
error_in_worldedit

Expected Behavior

When entering double slash commands expected to open worldedit commands

Reproduction Steps

  1. ...Open chat box
  2. ...type in '//' without the apostrophes
  3. ...error pops up without even entering command

Anything Else?

No response

"Cuboid Grid Color" and "Cuboid Edge Color" config options swapped

WorldEditCUI Version

1.19+01

Fabric Version

release fabric-loader-0.14.8-1.19.1

Fabric API Version

0.58.5+1.19.1

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

When I set the "Cuboid Grid Color" color in the config screen, (accessed from modmenu) the cuboid edge color changes.

Expected Behavior

When I set the "Cuboid Grid Color" color in the config screen, (accessed from modmenu) the cuboid grid color changes.

Reproduction Steps

  1. Open ModMenu
  2. Find WorldEditCUI
  3. Click on Configure (top right)
  4. Change Cuboid Grid Color to #FFFFFFFF
  5. Close the menu
  6. See how the edge color changes to white.

Anything Else?

no

Error when clearing selection with hotkey

WorldEditCUI Version

1.19+01

Fabric Version

Fabric 0.14.9

Fabric API Version

0.62.0+1.19.2

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

If I set a hotkey of clearing selection region and click that hotkey, MC crashes.

Expected Behavior

Clear the selection.

Reproduction Steps

  1. ...
  2. ...

Anything Else?

No response

Crashes when loading a single player world with multiconnect installed

WorldEditCUI Version

1.19+01

Fabric Version

0.14.8

Fabric API Version

0.57.0+1.19

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

Not sure if this is on multiconnect or WorldeditCUI to fix, but im making the ticket here regardless: When having both multiconnect and WorldeditCUI installed if it try to open a SP world i get kicked out with the following stack trace:

java.util.concurrent.RejectedExecutionException: event executor terminated
	at Not Enough Crashes deobfuscated stack trace.(1.19+build.4)
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:932)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:351)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:344)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:834)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:825)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:815)
	at net.earthcomputer.multiconnect.impl.PacketSystem.sendToServer(PacketSystem.java:155)
	at net.earthcomputer.multiconnect.protocols.generic.CustomPayloadHandler.forceSendIdentifierCustomPayload(CustomPayloadHandler.java:65)
	at net.earthcomputer.multiconnect.impl.APIImpl.forceSendCustomPayload(APIImpl.java:57)
	at org.enginehub.worldeditcui.fabric.CUINetworking.sendUnchecked(CUINetworking.java:42)
	at org.enginehub.worldeditcui.fabric.CUINetworking.send(CUINetworking.java:33)
	at org.enginehub.worldeditcui.fabric.FabricModWorldEditCUI.helo(FabricModWorldEditCUI.java:196)
	at org.enginehub.worldeditcui.fabric.FabricModWorldEditCUI.onTick(FabricModWorldEditCUI.java:144)
	at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents.lambda$static$2(ClientTickEvents.java:65)
	at net.minecraft.client.MinecraftClient.handler$bkd000$onEndTick(MinecraftClient:13890)
	at net.minecraft.client.MinecraftClient.tick(MinecraftClient:1869)
	at net.minecraft.client.MinecraftClient.render(MinecraftClient:1101)
	at net.minecraft.client.MinecraftClient.run(MinecraftClient:734)
	at net.minecraft.client.main.Main.main(Main:237)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

Expected Behavior

To work like it does in multiplayer.

Reproduction Steps

  1. Load/Make a single player map
  2. Crash

Anything Else?

No response

Keybinds are spammed when holding

Heya,

Just noticed, if you hold a keybind (or simply tap it too slowly), you'll end up spamming the action it's meant to perform (toggle view, clear selection, etc.). Just thought I'd mention seeing as this may cause people to get kicked for too many commands being issued.

Thanks,
Elliott

Selection event setMinMax is not supported for selection type Cuboid

[22:08:48] [main/INFO]: [STDERR]: com.mumfrey.worldeditcui.exceptions.InvalidSelectionTypeException: Selection event setMinMax is not supported for selection type Cuboid
[22:08:48] [main/INFO]: [STDERR]: 	at com.mumfrey.worldeditcui.render.region.Region.setMinMax(Region.java:108)
[22:08:48] [main/INFO]: [STDERR]: 	at com.mumfrey.worldeditcui.event.cui.CUIEventBounds.raise(CUIEventBounds.java:40)
[22:08:48] [main/INFO]: [STDERR]: 	at com.mumfrey.worldeditcui.event.CUIEventDispatcher.raiseEvent(CUIEventDispatcher.java:59)
[22:08:48] [main/INFO]: [STDERR]: 	at com.mumfrey.worldeditcui.event.listeners.CUIListenerChannel.onMessage(CUIListenerChannel.java:34)
[22:08:48] [main/INFO]: [STDERR]: 	at eu.mikroskeem.worldeditcui.FabricModWorldEditCUI.lambda$onPluginMessage$0(FabricModWorldEditCUI.java:130)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_1255.method_18859(class_1255.java:173)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_4093.method_18859(class_4093.java:23)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_1255.method_16075(class_1255.java:135)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_1255.method_5383(class_1255.java:115)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_310.method_1523(class_310.java:956)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_310.method_1514(class_310.java:619)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.client.main.Main.main(Main.java:204)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
[22:08:48] [main/INFO]: [STDERR]: 	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:193)
[22:08:48] [main/INFO]: [STDERR]: 	at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:138)
[22:08:48] [main/INFO]: [STDERR]: 	at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:26)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
[22:08:48] [main/INFO]: [STDERR]: 	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196)
[22:08:48] [main/INFO]: [STDERR]: 	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231)
[22:08:48] [main/INFO]: [STDERR]: 	at org.multimc.EntryPoint.listen(EntryPoint.java:143)
[22:08:48] [main/INFO]: [STDERR]: 	at org.multimc.EntryPoint.main(EntryPoint.java:34)
[22:08:48] [main/INFO]: [STDERR]: com.mumfrey.worldeditcui.exceptions.InvalidSelectionTypeException: Selection event setMinMax is not supported for selection type Cuboid
[22:08:48] [main/INFO]: [STDERR]: 	at com.mumfrey.worldeditcui.render.region.Region.setMinMax(Region.java:108)
[22:08:48] [main/INFO]: [STDERR]: 	at com.mumfrey.worldeditcui.event.cui.CUIEventBounds.raise(CUIEventBounds.java:40)
[22:08:48] [main/INFO]: [STDERR]: 	at com.mumfrey.worldeditcui.event.CUIEventDispatcher.raiseEvent(CUIEventDispatcher.java:59)
[22:08:48] [main/INFO]: [STDERR]: 	at com.mumfrey.worldeditcui.event.listeners.CUIListenerChannel.onMessage(CUIListenerChannel.java:34)
[22:08:48] [main/INFO]: [STDERR]: 	at eu.mikroskeem.worldeditcui.FabricModWorldEditCUI.lambda$onPluginMessage$0(FabricModWorldEditCUI.java:130)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_1255.method_18859(class_1255.java:173)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_4093.method_18859(class_4093.java:23)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_1255.method_16075(class_1255.java:135)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_1255.method_5383(class_1255.java:115)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_310.method_1523(class_310.java:956)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.class_310.method_1514(class_310.java:619)
[22:08:48] [main/INFO]: [STDERR]: 	at net.minecraft.client.main.Main.main(Main.java:204)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
[22:08:48] [main/INFO]: [STDERR]: 	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:193)
[22:08:48] [main/INFO]: [STDERR]: 	at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:138)
[22:08:48] [main/INFO]: [STDERR]: 	at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:26)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[22:08:48] [main/INFO]: [STDERR]: 	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
[22:08:48] [main/INFO]: [STDERR]: 	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196)
[22:08:48] [main/INFO]: [STDERR]: 	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231)
[22:08:48] [main/INFO]: [STDERR]: 	at org.multimc.EntryPoint.listen(EntryPoint.java:143)
[22:08:48] [main/INFO]: [STDERR]: 	at org.multimc.EntryPoint.main(EntryPoint.java:34)

Cannot build due to maven.terraformersmc.com returning HTTP 521

I downloaded the latest repo of the 1.17 branch and tried to build it using the gradlew.bat file.

Turns out I can't build the project because..

Could not GET 'https://maven.terraformersmc.com/releases/com/terraformersmc/modmenu/2.0.0-beta.7/modmenu-2.0.0-beta.7.pom'. Received status code 521 from server: Origin Down

That's basically saying that Cloudflare couldn't connect to the underlying server, so it's just down as of rn..

Is there anything I could do to fix this problem or do I have to wait for their servers to be online again?

Why no 1.17.1 yet?

I have been trying to find a version of WE CUI for 1.17.1 for over 2 months now, i really rely on the mod and it feels very weird not having it. When will it be updated?

Changing to GPLv3

Hi everyone, as part of inclusion in EngineHub we'd like to re-license the project to GPL so that we can potentially link it with WorldEdit or a common library if needed. Unfortunately, that means that we need permission from all copyright holders to change the license to GPLv3, as EPLv1 is not compatible with the GPL.

So, if you're mentioned below, please comment stating your approval or disapproval for us to change to GPLv3.

All other contributors I didn't include, as it appears their changes have been erased by the sands of time, or weren't significant (<100 lines), or weren't code changes. Notably, lahwran's code no longer appears to be part of the current HEAD repository, so I don't think we need their permission to switch the license.

If we don't get all responses by 2023, or we get a negative reply, I'll likely abandon the idea of moving this to GPL, but that might mean that I work on https://github.com/EngineHub/WorldEditVisualizer instead, since that is GPL-able.

Clipboard CUI

So this might be a little ambitious for now, but further down the line if you're still maintaining this - it would be a lovely addition to see.

What I suggest is a second CUI that would follow the player around, showing them the boundaries of their current clipboard to make for easier pasting. Similar to how the WorldEditSUI Spigot plugin does.

WorldEdit tool integration

Thinking a little bit about ways to gradually expand the functionality of the mod as time + interest allows...

WorldEdit's tools are often a bit tricky to use since there's no visual feedback about a) a certain item being a tool and b) what sort of action that tool might be able to do. WECUI could provide some help with that.

Initial steps

  1. Show the target block of the currently held tool, with an indication of whether the tool supports primary action, secondary action, or both
  2. Indicate that certain items are bound as WorldEdit tools (add to the items in inventory/hotbar)

The protocol this uses should allow WECUI to connect tools with both any item of a certain type (how WE currently handles tools), as well as specific ItemStacks (with something in the item's NBT data?).

A tool definition would carry one type Identifier (or perhaps multiple, to use in some sort of tags system) which describes the tool type, type-determined parameters (such as size, unique id (for eventually sending block volumes), tool name, or block pattern).

Longer-term

  1. Display an outline of the target area of a tool -- would have to know specific tool types. Could eventually go up to showing a ghost-image of what the brush's action area could look like
  2. Make the functionality easily extensible so other plugins that provide tool types can take advantage of the functionality
  3. Provide custom item textures for the tool types

Clearing selection with keystroke crashes the game

WorldEditCUI Version

1.19+01

Fabric Version

0.11.1

Fabric API Version

0.64.0+1.19.2

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

When I press my assigned key to clear the WorldEdit selection, the game saves, then promptly crashes. This is in singleplayer. Here's my crash log:
crash-2022-11-05_10.19.31-client.txt

Expected Behavior

The keystroke is supposed to clear the WorldEdit selection

Reproduction Steps

  1. Assign the "Clear WorldEdit Selection" Keystroke to anything
  2. Press that keystroke ingame in singleplayer with a region selected

Anything Else?

No response

Doesn't load with 1.17

Doesn't load with 1.17

The game crashed whilst unexpected error
Error: java.lang.NoSuchMethodError: 'void com.mojang.blaze3d.systems.RenderSystem.popMatrix()'
Exit Code: -1

Hidden Lines Rendering

To my eyes, rendering of hidden lines is different, but so subtle as to make it difficult to distinguish between those lines that should be visible and which are occluded, which in turn makes it hard to understand exactly what a selection includes.

I spent a brief amount of time trying to validate that the alpha blending is working well, or if I just needed to make the hidden lines more transparent, but didn't really come to any conclusions.

My question is, would it be appreciated if I made some effort to enhance the available options for line rendering... such as perhaps, not showing hidden grid lines, attenuating various lines with depth (i.e fog), or using other line styles (dashed/dotted etc).

Thanks

Looking along an axis a selection extends largely on renders incorrectly

WorldEditCUI Version

1.18.1+0.1

Fabric Version

Fabric 0.13.1

Fabric API Version

Fabric API 0.46.4+1.18

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

When standing far from the end points along an axis in which a selection extends largely on and looking along said axis, the lines rendered thicken (they become thicker the closer you get to the middle of the selection span). This occurs along any of the 3 axes. The larger the selection is, the thicker the lines become as well so it's not particularly noticeable on small selections.

Expected Behavior

I'd expect to see regular non-ultra thick lines

Reproduction Steps

  1. Make a really large selection along any axis
  2. Stand anywhere not near the end points of the selection on that axis
  3. Look along that axis

Anything Else?

Some screenshots showcasing the issue (looking along different axes, small/large selection, standing in the middle vs near an end point) https://imgur.com/a/8A3XoWc

Configuration menu

(this issue is just here as a reminder for myself and anyone else who can code & stumbles upon)

Pre-Fabric versions have config menus, this does not. Currently people have to modify json configuration file by hand to get desired settings.

Toggle view on and off.

The Problem

I'm not sure if this is already possible, and I just don't know how to do it, but if possible, I think it'd be nice to have this view togglable.

A Solution

For example, I'm trying to see what a certain colour block looks like in my build, but the lines are awfully distracting. It'd be nice to hide the grid for a moment, to see the blocks on their own. Just a though. Thanks for a great plugin none the less.

Alternatives

No response

Anything Else?

No response

minecraft crashes when cleaing selection

WorldEditCUI Version

1.19+01

Fabric Version

0.14.9-1.19.2

Fabric API Version

0.58.6+1.19.2

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

java.lang.NoSuchMethodError: 'void net.minecraft.class_746.method_44099(java.lang.String)'
at org.enginehub.worldeditcui.fabric.FabricModWorldEditCUI.onTick(FabricModWorldEditCUI.java:124)
at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents.lambda$static$2(ClientTickEvents.java:65)
at net.minecraft.class_310.handler$zdo000$onEndTick(class_310.java:3973)
at net.minecraft.class_310.method_1574(class_310.java:1907)
at net.minecraft.class_310.method_1523(class_310.java:1135)
at net.minecraft.class_310.method_1514(class_310.java:768)
at net.minecraft.client.main.Main.method_44604(Main.java:244)
at net.minecraft.client.main.Main.main(Main.java:51)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

Expected Behavior

not crash

Reproduction Steps

  1. open world
  2. press "Clear WorldEdit selection" button

Anything Else?

i'm not using any other mods only fabric api and worldedit

Break out protocol implementation into separate library

Currently both WECUI and WorldEdit have separate implementations of the same protocol, and no independent specification exists.

I'd like to break this implementation into a separate library, ideally licensed LGPL, to allow easily evolving the protocol between WorldEdit, WorldEditCUI, and whatever replacement may come along for WECUI. A secondary goal would be to allow non-WorldEdit plugins/mods to interact with the CUI from the server.

Along with this library I'd like to have proper documentation maintained for current and historical versions of the protocol (only starting from the current version unless someone is interested in further backwards compatibility).

Within this library we can consider possibilities for evolving the protocol like:

  • switching to a binary format
  • server-defined selection types
  • declaring tools

cc @octylFractal, thoughts?

1.18 Dev build crashing

WorldEditCUI Version

WorldEditCUI-1.16.5+03-SNAPSHOT.jar

Fabric Version

0.12.12

Fabric API Version

fabric-api-0.45.0+1.18.jar

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

I'm using fabulously-optimized via MultiMC so its most likely the problem, using latest dev build for 1.18.1 and it crashes as soon as I load into game.
Crashlog with full stats https://crashy.net/VhsKNkew38J1uc7trnw8

The modpack (To replace optifine)
https://www.curseforge.com/minecraft/modpacks/fabulously-optimized

The build I used:
https://github.com/EngineHub/WorldEditCUI/actions/runs/1619630616

Expected Behavior

Not crash.

Reproduction Steps

  1. Install MultiMC & fabulously-optimized
  2. Install latest dev build for WECUI
  3. Load a world/server

Anything Else?

No response

command that runs automatically

Hey,
How to disable the command that runs automatically on worldeditcui?

.... [18:21:40 INFO]: thedourn logged in with entity id 293 at ([Survie]-9.0, 78.0, -16.0)
.... [18:21:40 INFO]: thedourn issued server command: /we cui
.... [18:21:40 INFO]: thedourn lost connection: You used a command too fast! Please, join the server again and wait more before using any command.
.... [18:21:40 INFO]: [-] thedourn has left this server.

WorldEdit selection virualiser doesn't visible

WorldEditCUI Version

1.17.1+01-SNAPSHOT

Fabric Version

Fabric 0.12.12-1.17.1

Fabric API Version

Fabric API 0.45.2+1.17

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

On servers, the visual selection is not visible. It doesn't show on servers. I tried with FAWE, and WorldEdit plugin too in 1.17.1 paper server. I allowed the Debug mode and I saw the events what I got back. It seems to work, but its not.

Expected Behavior

It just not show the selected region, It not cause any error in logs or server console. No crash.

Reproduction Steps

  1. Install these mods what I wrote earlier and these too:

     VoxelMap-1.10.15_for_1.17.0
     FreeLook-Mod-Fabric-1.17.1 -> from Celibistrial
     modmenu-2.0.14
     optifabric-1.12.6
     OptiFine_1.17.1_HD_U_H1
    
  2. Run Paper server in 1.17,1

  3. Try with FAWE plugin.

Anything Else?

Here is some logs from the events:

[16:04:48] [Render thread/INFO]: [CHAT] (FAWE) First position set to (-101, 215, 102) (8).
[16:04:48] [Render thread/INFO]: Debug - Received CUI event from server: p|0|-101|215|102|8
[16:04:48] [Render thread/INFO]: Debug - CUI Event (p) - Params: 0, -101, 215, 102, 8
[16:04:48] [Render thread/INFO]: Debug - Setting point #0
[16:04:51] [Render thread/INFO]: [CHAT] (FAWE) Second position set to (-101, 215, 98) (5).
[16:04:51] [Render thread/INFO]: Debug - Received CUI event from server: p|1|-101|215|98|5
[16:04:51] [Render thread/INFO]: Debug - CUI Event (p) - Params: 1, -101, 215, 98, 5
[16:04:51] [Render thread/INFO]: Debug - Setting point #1

MultiMC Fabric missing fabric-keybindings and fabric-networking

Hi, I just tried to install and run WorldEditCUI, but it failed to launch. Here's the console log:

https://paste.ee/p/liYOR

MultiMC version: 0.6.7-1316
Minecraft folder is:
/Applications/MultiMC.app/Contents/MacOS/instances/1.14.4 fabric WorldEdit CUI/.minecraft
Java path is:
/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java
Java is version 1.8.0_221, using 64-bit architecture.

Main Class:
net.fabricmc.loader.launch.knot.KnotClient

Native path:
/Applications/MultiMC.app/Contents/MacOS/instances/1.14.4 fabric WorldEdit CUI/natives

Traits:
traits FirstThreadOnMacOS

Libraries:
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl/3.2.2/lwjgl-3.2.2.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl-jemalloc/3.2.2/lwjgl-jemalloc-3.2.2.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl-openal/3.2.2/lwjgl-openal-3.2.2.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl-opengl/3.2.2/lwjgl-opengl-3.2.2.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl-glfw/3.2.2/lwjgl-glfw-3.2.2.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl-stb/3.2.2/lwjgl-stb-3.2.2.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/com/mojang/patchy/1.1/patchy-1.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/oshi-project/oshi-core/1.1/oshi-core-1.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/net/java/dev/jna/jna/4.4.0/jna-4.4.0.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/net/java/dev/jna/platform/3.4.0/platform-3.4.0.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/com/ibm/icu/icu4j-core-mojang/51.2/icu4j-core-mojang-51.2.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/com/mojang/javabridge/1.0.22/javabridge-1.0.22.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/net/sf/jopt-simple/jopt-simple/5.0.3/jopt-simple-5.0.3.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/io/netty/netty-all/4.1.25.Final/netty-all-4.1.25.Final.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/com/google/guava/guava/21.0/guava-21.0.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/commons-io/commons-io/2.5/commons-io-2.5.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/commons-codec/commons-codec/1.10/commons-codec-1.10.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/com/mojang/brigadier/1.0.17/brigadier-1.0.17.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/com/mojang/datafixerupper/2.0.24/datafixerupper-2.0.24.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/com/google/code/gson/gson/2.8.0/gson-2.8.0.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/com/mojang/authlib/1.5.25/authlib-1.5.25.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/apache/commons/commons-compress/1.8.1/commons-compress-1.8.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/apache/httpcomponents/httpclient/4.3.3/httpclient-4.3.3.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/apache/httpcomponents/httpcore/4.3.2/httpcore-4.3.2.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/it/unimi/dsi/fastutil/8.2.1/fastutil-8.2.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/apache/logging/log4j/log4j-api/2.8.1/log4j-api-2.8.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/apache/logging/log4j/log4j-core/2.8.1/log4j-core-2.8.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/com/mojang/text2speech/1.11.3/text2speech-1.11.3.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/ca/weblite/java-objc-bridge/1.0.0/java-objc-bridge-1.0.0.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/net/fabricmc/intermediary/1.14.4/intermediary-1.14.4.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/net/fabricmc/tiny-mappings-parser/0.1.1.8/tiny-mappings-parser-0.1.1.8.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/net/fabricmc/sponge-mixin/0.7.11.38/sponge-mixin-0.7.11.38.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/net/fabricmc/tiny-remapper/0.1.0.40/tiny-remapper-0.1.0.40.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/net/fabricmc/fabric-loader-sat4j/2.3.5.4/fabric-loader-sat4j-2.3.5.4.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/com/google/jimfs/jimfs/1.1/jimfs-1.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/ow2/asm/asm/7.1/asm-7.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/ow2/asm/asm-analysis/7.1/asm-analysis-7.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/ow2/asm/asm-commons/7.1/asm-commons-7.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/ow2/asm/asm-tree/7.1/asm-tree-7.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/ow2/asm/asm-util/7.1/asm-util-7.1.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/net/fabricmc/fabric-loader/0.6.1+build.165/fabric-loader-0.6.1+build.165.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/com/mojang/minecraft/1.14.4/minecraft-1.14.4-client.jar

Native libraries:
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl/3.2.2/lwjgl-3.2.2-natives-macos.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl-jemalloc/3.2.2/lwjgl-jemalloc-3.2.2-natives-macos.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl-openal/3.2.2/lwjgl-openal-3.2.2-natives-macos.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl-opengl/3.2.2/lwjgl-opengl-3.2.2-natives-macos.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl-glfw/3.2.2/lwjgl-glfw-3.2.2-natives-macos.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/org/lwjgl/lwjgl-stb/3.2.2/lwjgl-stb-3.2.2-natives-macos.jar
/Applications/MultiMC.app/Contents/MacOS/libraries/ca/weblite/java-objc-bridge/1.0.0/java-objc-bridge-1.0.0-natives-osx.jar

Mods:
[✔️] WorldEditCUI-1.14.4_02

Params:
--username --version MultiMC5 --gameDir /Applications/MultiMC.app/Contents/MacOS/instances/1.14.4 fabric WorldEdit CUI/.minecraft --assetsDir /Applications/MultiMC.app/Contents/MacOS/assets --assetIndex 1.14 --uuid --accessToken --userType --versionType release

Window size: 854 x 480

Java Arguments:
[-Xdock:icon=icon.png, -Xdock:name="MultiMC: 1.14.4 fabric WorldEdit CUI", -XstartOnFirstThread, -Xms512m, -Xmx1024m, -Duser.language=en]

Minecraft process ID: 19711

Using onesix launcher.

[02:25:11] [main/INFO]: Loading for game Minecraft 1.14.4
Failed to start Minecraft:
Exiting with -1
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231)
at org.multimc.EntryPoint.listen(EntryPoint.java:143)
at org.multimc.EntryPoint.main(EntryPoint.java:34)
Caused by: java.lang.RuntimeException: Failed to resolve mods!
at net.fabricmc.loader.FabricLoader.load(FabricLoader.java:159)
at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:122)
at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:26)
... 8 more
Caused by: net.fabricmc.loader.discovery.ModResolutionException: Errors were found!

  • Mod worldeditcui depends on mod {fabric-keybindings-v0 @ [*]}, which is missing!
  • Mod worldeditcui depends on mod {fabric-networking-v0 @ [*]}, which is missing!
    at net.fabricmc.loader.discovery.ModResolver.findCompatibleSet(ModResolver.java:309)
    at net.fabricmc.loader.discovery.ModResolver.resolve(ModResolver.java:603)
    at net.fabricmc.loader.FabricLoader.load(FabricLoader.java:157)
    ... 10 more
    Process exited with code 255.
    Clipboard copy at: 18 Sep 2019 02:25:12 -0700
    Clipboard copy at: 18 Sep 2019 02:26:42 -0700
    MultiMC: Log upload triggered at: 18 Sep 2019 02:26:45 -0700

How can I get things in order?

(Question) worldeditcui and shaders

I had noticed that when shaders are on I can't see the borders at all :(, is there a way to fix it?
image

I don't want to fix it by removing the shaders, i am hopping for some kind of fix in the between :)

We need 1.17

The Problem

WorldEditCUI does not provide mods for version 1.17.X,but my Server base on 1.17.

A Solution

Is there a development plan for WorldEditCUI 1.17.X? If so, when will it be released?

Alternatives

No response

Anything Else?

No response

Chunk Border displays through blocks

WorldEditCUI Version

1.18.1+01

Fabric Version

Fabric 0.13.1

Fabric API Version

Fabric API 0.46.4

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

Turning on WECUI's chunk border display, shows through blocks which is quite disorienting and renders it fairly useless.

2022-02-12_12 51 41

The above screenshot taken running only Fabric, Fabric API and WECUI

Expected Behavior

Drawn lines to stop at blocks rather than showing through them

Reproduction Steps

  1. ... Turn on WECUI Chunk Borders

Anything Else?

No response

Update for 1.17 snapshots

With Fabric and WorldEdit both working on the latest snapshot(s) it'd be great for WorldEdit CUI to be updated as well.

[Request] Different grid color in the middle of the selection

It would be great, if you could add an option to have a different line color for the lines in the middle of the selection. So there would be 2 (for an uneven length) or 3 (for an even length) lines with a different color on each side of the cuboid selection. They would highlight the center-blocks and it would be a nice building-aid.

Far-away selection grids look bad

(ok, yes, it's a subjective title... sorry)

But anyways, looking at a large selection, as grid lines get further away perspective makes them appear closer together, and before culling kicks in the lines already dominate the view.

The culling implementation is also fairly ugly -- it's a hard cutoff at 128 blocks away (and I think some issues with its math are why the selection grid can appear to move with the camera in some cases). If this culling can be replaced with some sort of exponential? spacing of grid lines i'd expect nicer results.

2020-07-06_12 22 16

Can't see anything with big selection, and it's pretty hard to see anything in general

WorldEditCUI Version

1.19+01

Fabric Version

Quilt 0.17.4

Fabric API Version

I have no idea...

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEditCUI compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.

Bug Description

If you have a big selection, you pretty much can't see anything anymore.

And in general, it's very hard to see anything when having a selection.

2022-10-15_20 07 33
2022-10-15_20 07 37

Expected Behavior

You should be able to see

Reproduction Steps

  1. Make a big selection
  2. Try to see

Anything Else?

No response

Fix or remove "Always on top setting"

This setting hasn't been implemented since the LiteLoader era -- either it should be added if it's actually necessary, or just removed. I think there are other ways we can achieve mod compatibility?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.