ensdomains / resolvers

A collection of resolvers for ENS domains

This repo is now consolidated into https://github.com/ensdomains/ens-contracts

resolvers's Issues

[email protected]

npm package @ensdomains/resolver is not up to date

The title is pretty much self-explanatory. By adding @ensdomains/resolver I expected to pull this repo ... but it is not the case.

I believe it would help with people setting up test environments to be able to pull this repo just like @ensdomains/ens.

Verify ENS entry on an external device?

I'm not sure if this is the proper place to fire up this conversation, but I'm a huge fan of ENS. I've been chasing Ledger to implement support for ENS in the last several months and finally I received a reply from their CTO. He said

We'd be interested to give it a look after finding a way (as decentralized as possible, ideally) to verify an ENS entry on device

Sounds to me like these guys need a way to verify the ENS domain-address pair on an external offline device (the Ledger wallet itself) to avoid spoofing or man-in-the-middle attacks. Is there a way to achieve this?

The discussion is on their subreddit

Cannot resolve `CustodialPublicResolver.json`

It seems like the newest version of @ensdomains/resolver is broken due to a missing artifact.

Currently it is breaking Truffle's build with an error saying that it cannot resolve CustodialPublicResolver.json from the package folder in node_modules. I looked at the source code and line 1 of index.js has

const CustodialPublicResolver = require('./build/contracts/CustodialPublicResolver.json')

but there is no JSON file of that name in the location mentioned.

When I clone this repo and compile, it also does not have the above-mentioned artifact. For the moment we are going to pin to 0.1.12. Perhaps I am doing something incorrectly? Please let me know if I am missing something.

Thank

Add EthDNS resolver as DNSResolver?

There was some discussion back at devcon about adding the EthDNS resolver (at https://github.com/wealdtech/wealdtech-solidity/blob/master/contracts/ens/DNSResolver.sol) to the resolvers package. Is this something you're still interested in? If so I'll put together a PR.

Make resolvers set their ABIs in their reverse records

That way, anyone looking up a resolver can trivially interact with it.

Is the event field `indexedKey` supposed to be indexed?

The field from the event appears that it is supposed to be indexed, but it isn't:

resolvers/contracts/profiles/TextResolver.sol

Line 8 in f0ef9c9

event TextChanged(bytes32 indexed node, string indexedKey, string key);

Also, it appears it was indexed long ago in the past, as seen by this event:
https://etherscan.io/tx/0xf49facd89a265d0bc2a8ea79965b48dd577fbafc2e355905e41492e17656b086#eventlog

I can across then when updating the ENS subgraph - https://github.com/graphprotocol/ens-subgraph/tree/master-backup

Seems like the word indexed might have been removed when upgrading the contract?

addr() should return an address payable

Currently, AddrResolver's addr() function returns an address, but often the purpose of resolving an address is to send ether to it. So it seems to me that it should return an address payable.

Although, this might cause backward compatibility issues with existing contracts. So maybe the best solution is to recommend a workaround for the calling contract (some way to cast an address to an address payable), but it's my understanding that a workaround like this was deliberately made difficult. Not sure what is best.

Add Resolver interfaces