This repo is now consolidated into https://github.com/ensdomains/ens-contracts
ensdomains / resolvers Goto Github PK
View Code? Open in Web Editor NEWA collection of resolvers for ENS domains
License: BSD 2-Clause "Simplified" License
A collection of resolvers for ENS domains
License: BSD 2-Clause "Simplified" License
This repo is now consolidated into https://github.com/ensdomains/ens-contracts
The title is pretty much self-explanatory. By adding @ensdomains/resolver I expected to pull this repo ... but it is not the case.
I believe it would help with people setting up test environments to be able to pull this repo just like @ensdomains/ens.
I'm not sure if this is the proper place to fire up this conversation, but I'm a huge fan of ENS. I've been chasing Ledger to implement support for ENS in the last several months and finally I received a reply from their CTO. He said
We'd be interested to give it a look after finding a way (as decentralized as possible, ideally) to verify an ENS entry on device
Sounds to me like these guys need a way to verify the ENS domain-address pair on an external offline device (the Ledger wallet itself) to avoid spoofing or man-in-the-middle attacks. Is there a way to achieve this?
The discussion is on their subreddit
It seems like the newest version of @ensdomains/resolver
is broken due to a missing artifact.
Currently it is breaking Truffle's build with an error saying that it cannot resolve CustodialPublicResolver.json
from the package folder in node_modules
. I looked at the source code and line 1 of index.js
has
const CustodialPublicResolver = require('./build/contracts/CustodialPublicResolver.json')
but there is no JSON file of that name in the location mentioned.
When I clone this repo and compile, it also does not have the above-mentioned artifact. For the moment we are going to pin to 0.1.12
. Perhaps I am doing something incorrectly? Please let me know if I am missing something.
There was some discussion back at devcon about adding the EthDNS resolver (at https://github.com/wealdtech/wealdtech-solidity/blob/master/contracts/ens/DNSResolver.sol) to the resolvers package. Is this something you're still interested in? If so I'll put together a PR.
That way, anyone looking up a resolver can trivially interact with it.
The field from the event appears that it is supposed to be indexed, but it isn't:
Also, it appears it was indexed long ago in the past, as seen by this event:
https://etherscan.io/tx/0xf49facd89a265d0bc2a8ea79965b48dd577fbafc2e355905e41492e17656b086#eventlog
I can across then when updating the ENS subgraph - https://github.com/graphprotocol/ens-subgraph/tree/master-backup
Seems like the word indexed might have been removed when upgrading the contract?
Currently, AddrResolver's addr() function returns an address, but often the purpose of resolving an address is to send ether to it. So it seems to me that it should return an address payable.
Although, this might cause backward compatibility issues with existing contracts. So maybe the best solution is to recommend a workaround for the calling contract (some way to cast an address to an address payable), but it's my understanding that a workaround like this was deliberately made difficult. Not sure what is best.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.