eouia / mmm-volvooncall Goto Github PK

First of all, thank you eouia for making this possible!
It is not really an issue but I would really like to have the information displayed in my own language (Dutch).

Which file do I edit? (I've looked a bit already but couldn't find it) to change the strings display "Door Lock" "Engine" etc. etc. I want to change those to my own language.
Maybe this is more of a feature request than an issue...

Also, I would really like to have the possibility to select which items I want to display.
For instance, I would only like to be able to see if my doors/windows are locked, and don't care about about engine or brake fluid information on my MM.

Again, thank you for making this possible.

Love the module and works fantastic. Took me a little while to get position info working and had to do some digging, but eventually found a potential bug in the code used to format the position value.

The regex used in node_helper.js within the reformValue function has a hole which means it falls over and returns a null position object, if the returned lat or long is negative.

I fixed this within my implementation by changing the following line:

var re = /([0-9.]+),\s([0-9.]+),\s'([^\']+)'/

to this:

var re = /([0-9.-]+),\s([0-9.-]+),\s'([^\']+)'/

Just escapes the '-' for negative lat and long values being returned.

Thought it was worth a mention and not sure if you had already found and resolved this issue, or whether you had given up development of this module.

Once again, awesome module and absolutely love your work. Hope the above helps.