ericsson / puppet-module-cron Goto Github PK

Are there any plans to publish this module on the forge?

Would be great if this module supported EL7.

some variable names should be renamed for easier understanding
$enable_cron -> $service_enable
$ensure_state -> $service_ensure

SLE[S|D] 10 machines need an empty /etc/cron.deny file or the cron daemon shuts down.

Fixed locally by adding this to hiera for SLE[S|D] machines, it just creates the empty file.

cron::cron_deny_users:

Please ?

Suggest adding a parameter, fragments, to the cron class that use create_resources() to create cron::fragment definitions. This is similar to https://github.com/ghoneycutt/puppet-module-types/blob/master/manifests/init.pp

validate $cron_files being a hash before creating the resources

I believe the tag changed from v2.0.0 -> 2.0.0

Tags are meant to be immutable so everyone using v2.0.0 would be broken. If you mistakenly created a tag, the best thing would be to checkout it out and create a new tag based on that and push that one.

Noticed a merge though it was not released.