erikdmitchell / koksijde Goto Github PK

A robust theme built using the bootstrap framework with a touch of awesomeness.

Home Page: https://wordpress.org/themes/koksijde/

License: Other

PHP 61.08% CSS 22.91% JavaScript 16.01%

koksijde's Introduction

=== koksijde ===
Contributors: Erik Mitchell
Tags: featured-images, custom-menu, theme-options, translation-ready
Requires at least: 3.5
Tested up to: 4.8.2
Stable tag: 1.1.0
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html

A robust theme built using the bootstrap framework with a touch of awesomeness.

== Description ==

A robust theme built using the bootstrap framework with a touch of awesomeness.

We recommend you create a child theme of this theme for further customizations as this theme will offer updates periodically.

== Installation ==

1. Upload `koksijde` to the `/wp-content/theme/` directory
2. Activate the theme through the 'Themes' (Appearance) menu in WordPress

== Copyright --

Koksijde bundles the following third-party resources:

HTML5 Shiv v3.7.3, Copyright 2014 Alexander Farkas
**Licenses**: MIT/GPL2
Source: https://github.com/aFarkas/html5shiv

Respond.js, Copyright 2011 Scott Jehl
**Licenses**: MIT
Source: https://github.com/scottjehl/Respond

jQuery Actual Plugin, Copyright 2012 Ben Lin
**Licenses**: MIT
Source: https://github.com/dreamerslab/jquery.actual

Bootstrap, Copyright 2016 Twitter
**Licenses**: MIT
Source: http://getbootstrap.com

Glyphicons, Copyright 2010 Jan Kovarik
**Licenses**: Creative Commons Attribution, version 3.0
Source: http://glyphicons.com

Font Awesome icons, Copyright Dave Gandy
**License:** SIL Open Font License, version 1.1.
Source: http://fontawesome.io

Bundled screenshot image, Copyright Alvin Engler
**License:** CC0 1.0 Universal (CC0 1.0)
Source: http://www.burningwell.org/gallery2/v/Landscapes/ocean/michelle_049.jpg.html, http://www.burningwell.org/gallery2/v/Objects/Windmill.jpg.html, http://www.burningwell.org/gallery2/main.php?g2_view=dynamicalbum.UpdatesAlbum&amp;g2_itemId=25774, http://www.burningwell.org/gallery2/v/Landscapes/ocean/IMG_0767.JPG.html

== Changelog ==

= 1.1.0 =

 * Leveraged customizer for the front page
 * Fixed slider issues and moved it into a "Home" panel in the customizer.

= 1.0.0 =

 * Initial setup and theme build out.

koksijde's People

Contributors

Watchers

koksijde's Issues

Add translation ready tag in style.css

Look into this and fix.

inc\customizer.php

you can't use esc_attr to sanitize all the settings

check this out

You need to provide license information for any assets used in your theme

See: this

Applies to:

html5shiv.js, respond.js, jquery.actual.js, glyphicons
the images used in your screenshot

Proper license and attribution of the resources

Proper license and attribution of the resources(likes, images, js, css, fonts) used by theme not found
Please go through this link

Functions prefix issue

Function prefix missing in functions.php line 349

Slider Issue

This was setup properly via the Customizer, but is not working.

There is a js error.

See J4K for more.

inc\slider.php

L17 after_setup_theme
L52, 73 you forgot the filter name

inc\theme-meta.php

you can't remove/add:

meta description - plugin territory
meta author - plugin territory
koksijde_disable_seo_meta() not really the place for a theme

I would say, most likely, we remove this file

Mobile menu shows by default

Mobile menu is displaying on non mobile devices/screen sizes.

functions.php

L39, use underscores _ instead of - when naming a filter
same in inc\slider.php:L136,164,165
remove L163
Recommended: 3rd party scripts/style don't need the suffix -script or -style
remove L178-182, no need to register them and use wp_add_script_data() link (check the User Contributed Notes)
L218,242 - get_permalink() needs to be escaped
remove koksijde_theme_paging_nav() and use the_posts_pagination(), has filters you can use to change the output
remove koksijde_theme_post_nav() and use the_post_navigation() has filters you can use to change the output
L373, escape all the attributes, absint() for numbers esc_url() for href

Slider causes js issue

There's a js issue when no slider exists.

Check the calls and disable the js if no slider.

Fix javascript issues

SyntaxError: expected expression, got '<'.../koksijde/inc/js/koksijde-theme.js?ver=1.2.0 line 1
TypeError: f[0] is undefined .../koksijde/inc/js/bootstrap.min.js?ver=3.3.2 line 6

Pull in Theme Addons

With full integration into customizer, theme options is being removed.

We may want to add our theme add-ons in.

//'http://www.millerdesignworks.com/mdw-wp-plugins/mdw-full-bg-slider.json'

Remove WP package from files

Remove @package WordPress from your files

Slider

Issues:

is broken if the posts don't have post thumbnails
you need to escape the output for each option you use in these files, in template-parts\home-slider folder

Integrate Theme Options into Customizer

Theme are not allowed to add Theme Option in Dashboard, please add the Theme Option inside customizer

inc\wp_bootstrap_navwalker.php

the Class name needs to be prefixed or check if it exists. You can also update to the latest version, it has the check

See: https://github.com/wp-bootstrap/wp-bootstrap-navwalker

Needs to be translatable

header.php:L26
footer.php - Change date( 'Y' ) to date_i18n( esc_html__( 'Y', 'text-domain' ) )

archive.php

replace L21-29 with the_archive_title()

Valid screenshot.png

Screenshot.png included in file is not valid please update it

Globalize $content_width

Something like this: https://github.com/Automattic/_s/blob/master/functions.php#L78

Add theme slug to add image size

Add theme slug in add image size functions.php line 69

WARNING: The tag white has been deprecated, please remove it from your style.css header.
WARNING: The tag responsive-layout has been deprecated, please remove it from your style.css header.
WARNING: The tag light has been deprecated, please remove it from your style.css header.

erikdmitchell / koksijde Goto Github PK

koksijde's Introduction

koksijde's People

Contributors

Watchers

koksijde's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs