eriklax / xva-img Goto Github PK

Hi @eriklax,
the --version parameter does not reflect the version of xva-img, but that of the compiler.

Hi having some problems with deleted files and needing to do forensics on a client machine,
I want to run xva-img directly on xenserver but the distribution is very limited and building on that machine is no fun at all.
So I build externallly on a debian machine.
As xva-img is a smalll tool and disk space is not the big deal today I like to have rescue tools to be statically linked.
So please add an option to statically link xva-img.

Thanks in advance!

Levush

I don't know how this is done with CMake, but I'm sure there are some standard methods to derive the correct directory from some defaults plus environment or commandline options with CMake, too.

Actually, if I want to install it into /usr/bin/ instead of /usr/local/bin/, the common way to achieve this with CMake is to pass -DCMAKE_INSTALL_PREFIX=/usr on the commandline. But with xva-img, this setting is completely ignored.

Hi!
I try to recover a XVA, but when i export a disk, an error shows:
xva-img: invalid xxh64 checksum for 00039419
can i do anything?

Thanks in advance.

Install g++ cmake make libssl-dev
cmake .
make
make install

You're welcome.

are you able to update your project accordingly or not?

CMake Warning (dev) at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 2.4 is not supported by CMake >= 3.0.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- The CXX compiler identification is unknown
CMake Error at CMakeLists.txt:6 (PROJECT):
  No CMAKE_CXX_COMPILER could be found.

  Tell CMake where to find the compiler by setting either the environment
  variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
  to the compiler, or to the compiler name if it is in the PATH.


-- Configuring incomplete, errors occurred!

When running make install I get the error:

Scanning dependencies of target xva-img
[ 11%] Building CXX object CMakeFiles/xva-img.dir/src/disk.cpp.o
[ 22%] Building CXX object CMakeFiles/xva-img.dir/src/main.cpp.o
[ 33%] Building CXX object CMakeFiles/xva-img.dir/src/package.cpp.o
[ 44%] Building CXX object CMakeFiles/xva-img.dir/src/progress.cpp.o
[ 55%] Building CXX object CMakeFiles/xva-img.dir/src/readfile.cpp.o
[ 66%] Building CXX object CMakeFiles/xva-img.dir/src/sha1.cpp.o
[ 77%] Building CXX object CMakeFiles/xva-img.dir/src/writefile.cpp.o
[ 88%] Building CXX object CMakeFiles/xva-img.dir/src/xxh64.cpp.o
/home/user/xva-img/src/xxh64.cpp:34:10: fatal error: xxhash.h: No such file or directory
#include <xxhash.h>
^~~~~~~~~~
compilation terminated.
CMakeFiles/xva-img.dir/build.make:230: recipe for target 'CMakeFiles/xva-img.dir/src/xxh64.cpp.o' failed
make[2]: *** [CMakeFiles/xva-img.dir/src/xxh64.cpp.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/xva-img.dir/all' failed
make[1]: *** [CMakeFiles/xva-img.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

I'm currently looking into packaging xva-img for Debian, see https://bugs.debian.org/854490.

Your code is under GPL and the GPL is incompatible with some terms of the OpenSSL license. This makes Debian (and probably other distributions, too) not allowing GPL-licensed code to be linked with OpenSSL libraries unless there is a license exception explicitly permitting this.

To grant such an exception, it should suffice to add these paragraphs to whereever the GPL preamble is used (and probably also to the LICENSE file):

In addition, as a special exception, the copyright holders give permission to link the code of portions of this program with the OpenSSL library under certain conditions as described in each individual source file, and distribute linked combinations including the two.

You must obey the GNU General Public License in all respects for all of the code used other than OpenSSL. If you modify file(s) with this exception, you may extend this exception to your version of the file(s), but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. If you delete this exception statement from all source files in the program, then also delete it here.

Alternatively (but surely more effort) would be to also support GnuTLS as alternative to OpenSSL.

XVA files exported from XenServer and XCP-ng now use xxhash. Exporting fails to find .checksum files.

hello,

it seems like the compiled program has a size limitation on 2 GigaByte on 32-bit systems when packaging a xva file.
While the packaging process the program throws the error "unable to write data for myvm:Ref:25/00002044". If I check the output file it says 2 GigaByte of size (detailed view: 2.147.483.648 / the exact size of an 32-bit integer).

Sorry about the vague title but I am not too familiar with how version selection works with CMake or C++ in general.

I just built xva-img on Ubuntu Xenial.

Initially I got errors, these with GCC:

[ 12%] Building CXX object CMakeFiles/xva-img.dir/src/disk.cpp.o
In file included from xva-img-1.4.2/src/disk.cpp:48:0:
xva-img-1.4.2/src/disk.hpp:45:5: warning: identifier ‘noexcept’ is a keyword in C++11 [-Wc++0x-compat]
     noexcept(false);
     ^
xva-img-1.4.2/src/disk.hpp:44:43: error: expected ‘;’ at end of member declaration
    bool Export(const std::string& diskpath)
                                           ^
xva-img-1.4.2/src/disk.hpp:45:14: error: expected identifier before ‘false’
     noexcept(false);
              ^
xva-img-1.4.2/src/disk.hpp:45:14: error: expected ‘,’ or ‘...’ before ‘false’
xva-img-1.4.2/src/disk.hpp:45:19: error: ISO C++ forbids declaration of ‘noexcept’ with no type [-fpermissive]
     noexcept(false);
                   ^
xva-img-1.4.2/src/disk.hpp:46:43: error: expected ‘;’ at end of member declaration
    bool Import(const std::string& diskpath)
                                           ^
xva-img-1.4.2/src/disk.hpp:47:14: error: expected identifier before ‘false’
     noexcept(false);
              ^
xva-img-1.4.2/src/disk.hpp:47:14: error: expected ‘,’ or ‘...’ before ‘false’
xva-img-1.4.2/src/disk.hpp:47:19: error: ISO C++ forbids declaration of ‘noexcept’ with no type [-fpermissive]
     noexcept(false);
                   ^
xva-img-1.4.2/src/disk.hpp:47:5: error: ‘int XVA::Disk::noexcept(int)’ cannot be overloaded
     noexcept(false);
     ^
xva-img-1.4.2/src/disk.hpp:45:5: error: with ‘int XVA::Disk::noexcept(int)’
     noexcept(false);
     ^
xva-img-1.4.2/src/disk.cpp:60:2: error: expected initializer before ‘noexcept’
  noexcept(false)
  ^
CMakeFiles/xva-img.dir/build.make:62: recipe for target 'CMakeFiles/xva-img.dir/src/disk.cpp.o' failed

and these with Clang:

[ 12%] Building CXX object CMakeFiles/xva-img.dir/src/disk.cpp.o
In file included from xva-img-1.4.2/src/disk.cpp:48:
xva-img-1.4.2/src/disk.hpp:44:44: error: expected ';' at end of declaration list
                        bool Export(const std::string& diskpath)
                                                                ^
                                                                ;
xva-img-1.4.2/src/disk.hpp:46:44: error: expected ';' at end of declaration list
                        bool Import(const std::string& diskpath)
                                                                ^
                                                                ;
xva-img-1.4.2/src/disk.cpp:60:2: error: expected function body after function declarator
        noexcept(false)
        ^
3 errors generated.
CMakeFiles/xva-img.dir/build.make:62: recipe for target 'CMakeFiles/xva-img.dir/src/disk.cpp.o' failed

The solution was to run cmake -DCMAKE_CXX_STANDARD=11 -DCMAKE_CXX_STANDARD_REQUIRED=ON . instead of just cmake .. This makes it build with both GCC and Clang.

I created a docker of this project so I didn't need to have the dependencies on my local machine. I thought I would share. Let me know if you have any suggestions or issues.

https://github.com/marleyjaffe/xva-img_docker

Successfully ran cmake .:

$> cmake .
-- The C compiler identification is GNU 4.9.1
-- The CXX compiler identification is GNU 4.9.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Configuring done
-- Generating done
-- Build files have been written to: /vmstorage/01/playground/xva-img-master

but the make install failed:

$> make install
[ 14%] Building CXX object CMakeFiles/xva-img.dir/src/sha1.o
/vmstorage/01/playground/xva-img-master/src/sha1.cpp:20:25: fatal error: openssl/sha.h: No such file or directory
 #include <openssl/sha.h>
                         ^
compilation terminated.
CMakeFiles/xva-img.dir/build.make:54: recipe for target 'CMakeFiles/xva-img.dir/src/sha1.o' failed
make[2]: *** [CMakeFiles/xva-img.dir/src/sha1.o] Error 1
CMakeFiles/Makefile2:60: recipe for target 'CMakeFiles/xva-img.dir/all' failed
make[1]: *** [CMakeFiles/xva-img.dir/all] Error 2
Makefile:113: recipe for target 'all' failed
make: *** [all] Error 2

Looks like there are problems with openssl?